pay-ui is difficult to maintain and introduces complexity as a click package
Bug #1535420 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Alejandro J. Cura | ||
| pay-service (Ubuntu) |
Fix Released
|
High
|
dobey | ||
Bug Description
Currently pay-ui is a click package as a way to satisfy some requirements that never became actual requirements. This makes it difficult to maintain with respect to changes in pay-service, as it has to be manually tested and uploaded to the store outside of CI train. This also introduces extra complexity in pay-service itself, as it has to find the pay-ui from the click package and launch it. The separation also makes it more difficult to solve some more complex interaction issues.
We should move pay-ui into pay-service as a core part of the system to solve these problems.
Related branches
lp:~dobey/pay-service/merge-payui
- Charles Kerr (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 10389 lines (+9058/-472)107 files modified.bzrignore (+3/-2)
CMakeLists.txt (+1/-2)
HACKING (+85/-0)
debian/control (+22/-4)
debian/copyright (+2/-2)
debian/pay-service.click-hook (+0/-4)
debian/pay-service.install (+2/-2)
debian/pay-ui.install (+3/-0)
debian/rules (+1/-1)
pay-ui/CMakeLists.txt (+21/-0)
pay-ui/app/CMakeLists.txt (+6/-0)
pay-ui/app/components/AlertDialog.qml (+31/-0)
pay-ui/app/components/BeforeUnloadDialog.qml (+37/-0)
pay-ui/app/components/CMakeLists.txt (+6/-0)
pay-ui/app/components/ConfirmDialog.qml (+37/-0)
pay-ui/app/components/ModalDialog.qml (+32/-0)
pay-ui/app/components/PromptDialog.qml (+51/-0)
pay-ui/app/components/SecurityCertificatePopover.qml (+145/-0)
pay-ui/app/payui.qml (+459/-0)
pay-ui/app/tests/unit/js/unit_test.js (+17/-0)
pay-ui/app/tests/unit/tst_checkoutpage.qml (+73/-0)
pay-ui/app/tests/unit/tst_purchasewebkit.qml (+57/-0)
pay-ui/app/ui/CMakeLists.txt (+6/-0)
pay-ui/app/ui/CheckoutPage.qml (+404/-0)
pay-ui/app/ui/ErrorDialog.qml (+67/-0)
pay-ui/app/ui/UbuntuPurchaseWebkit.qml (+107/-0)
pay-ui/backend/CMakeLists.txt (+49/-0)
pay-ui/backend/modules/payui/backend.cpp (+23/-0)
pay-ui/backend/modules/payui/backend.h (+33/-0)
pay-ui/backend/modules/payui/certificateadapter.cpp (+46/-0)
pay-ui/backend/modules/payui/certificateadapter.h (+51/-0)
pay-ui/backend/modules/payui/credentials_service.cpp (+81/-0)
pay-ui/backend/modules/payui/credentials_service.h (+53/-0)
pay-ui/backend/modules/payui/network.cpp (+512/-0)
pay-ui/backend/modules/payui/network.h (+136/-0)
pay-ui/backend/modules/payui/oxideconstants.cpp (+19/-0)
pay-ui/backend/modules/payui/oxideconstants.h (+53/-0)
pay-ui/backend/modules/payui/pay_info.cpp (+37/-0)
pay-ui/backend/modules/payui/pay_info.h (+73/-0)
pay-ui/backend/modules/payui/purchase.cpp (+154/-0)
pay-ui/backend/modules/payui/purchase.h (+59/-0)
pay-ui/backend/modules/payui/qmldir (+2/-0)
pay-ui/backend/tests/CMakeLists.txt (+30/-0)
pay-ui/backend/tests/mock_click_server.py (+162/-0)
pay-ui/backend/tests/test_network.cpp (+317/-0)
pay-ui/pay-ui.in (+19/-0)
pay-ui/tests/autopilot/pay_ui/__init__.py (+106/-0)
pay-ui/tests/autopilot/pay_ui/tests/__init__.py (+77/-0)
pay-ui/tests/autopilot/pay_ui/tests/mock_server.py (+337/-0)
pay-ui/tests/autopilot/pay_ui/tests/test_pay_ui.py (+186/-0)
pay-ui/tests/autopilot/run_autopilot (+1/-0)
po/CMakeLists.txt (+1/-1)
po/POTFILES.in (+8/-0)
po/aa.po (+106/-0)
po/am.po (+106/-0)
po/ast.po (+106/-0)
po/az.po (+106/-0)
po/br.po (+106/-0)
po/ca.po (+106/-0)
po/ca@valencia.po (+106/-0)
po/cs.po (+106/-0)
po/cy.po (+106/-0)
po/de.po (+106/-0)
po/el.po (+106/-0)
po/en_AU.po (+106/-0)
po/en_GB.po (+106/-0)
po/es.po (+106/-0)
po/eu.po (+106/-0)
po/fa.po (+106/-0)
po/fi.po (+106/-0)
po/fr.po (+106/-0)
po/gd.po (+107/-0)
po/gl.po (+106/-0)
po/he.po (+106/-0)
po/hu.po (+106/-0)
po/id.po (+106/-0)
po/is.po (+106/-0)
po/it.po (+106/-0)
po/ja.po (+106/-0)
po/ko.po (+106/-0)
po/nb.po (+106/-0)
po/nl.po (+106/-0)
po/pay-service.pot (+82/-2)
po/pl.po (+106/-0)
po/pt.po (+106/-0)
po/pt_BR.po (+106/-0)
po/ro.po (+106/-0)
po/ru.po (+106/-0)
po/sl.po (+106/-0)
po/sq.po (+106/-0)
po/sr.po (+106/-0)
po/sv.po (+107/-0)
po/ug.po (+106/-0)
po/uk.po (+106/-0)
po/vi.po (+106/-0)
po/zh_CN.po (+106/-0)
po/zh_TW.po (+106/-0)
service-ng/src/launchpad.net/go-mir/mir/fakes/prompt_session.go (+5/-1)
service-ng/src/launchpad.net/go-mir/mir/mir_prompt_session_helper.c (+41/-0)
service-ng/src/launchpad.net/go-mir/mir/mir_prompt_session_helper.h (+28/-0)
service-ng/src/launchpad.net/go-mir/mir/prompt_session.go (+14/-1)
service-ng/src/pay-service-2/service/pay_ui.go (+18/-83)
service-ng/src/pay-service-2/service/pay_ui_test.go (+8/-199)
service-ng/test-service.sh (+2/-2)
tests/setup-staging.sh (+0/-8)
ual-helper/CMakeLists.txt (+0/-12)
ual-helper/exec-tool.c (+0/-146)
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → High |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| Changed in pay-ui: | |
| assignee: | nobody → Rodney Dawes (dobey) |
| Changed in canonical-devices-system-image: | |
| milestone: | none → ww08-2016 |
| Changed in canonical-devices-system-image: | |
| status: | New → Incomplete |
| status: | Incomplete → Confirmed |
| Changed in pay-ui: | |
| status: | Triaged → In Progress |
| Changed in pay-service (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Rodney Dawes (dobey) |
| importance: | Undecided → High |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in pay-service (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Committed |
| Changed in pay-ui: | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package pay-service - 15.10+16.
---------------
pay-service (15.10+
* Merge pay-ui into pay-service. (LP: #1535420, #1432031)
-- Rodney Dawes <email address hidden> Fri, 11 Mar 2016 14:50:53 +0000