Purchase not treated as failed on dbus errors
Bug #1526929 reported by
dobey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Critical
|
Alejandro J. Cura | ||
pay-service (Ubuntu) |
Fix Released
|
Critical
|
dobey | ||
qtpurchasing-opensource-src (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
The purchase is not being treated as failing when a dbus error is returned after attempting to start a purchase, as is the case when the app has been denied access to the purchasing API. This can cause some slightly odd behavior in apps that expect to see a success/fail condition after attempting to purchase an item.
Related branches
lp:~dobey/pay-service/error-setstatus
- Charles Kerr (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 128 lines (+59/-6)3 files modifiedlibpay/internal/package.cpp (+27/-5)
tests/com_canonical_pay_store.py (+6/-1)
tests/libpay-package-tests.cpp (+26/-0)
Changed in pay-service (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Rodney Dawes (dobey) |
importance: | Undecided → Critical |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Alejandro J. Cura (alecu) |
importance: | Undecided → Critical |
milestone: | none → ww02-2016 |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
milestone: | ww02-2016 → ww08-2016 |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package pay-service - 15.10+16. 04.20160114- 0ubuntu1
--------------- 16.04.20160114- 0ubuntu1) xenial; urgency=medium
pay-service (15.10+
* Add trust-store integration for requests to purchase items.
Introduce translations support, as trust-store had a displayed
string. (LP: #1524943)
* Call observer with status UNKNOWN and refund timeout of 0 on error.
(LP: #1526929)
* Fix typo in setup-staging.sh. Also include remounting / in setup-
staging.sh to enable writable for key. (LP: #1533242)
* Pull in the gettext package for golang.
* Update to handle purchase correctly after server has been fixed.
(LP: #1524941)
-- Rodney Dawes <email address hidden> Thu, 14 Jan 2016 03:17:44 +0000