Canonical System Image

Remove the new private header usage from webbrowser-app

Bug #1491806 reported by Timo Jyrinki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
In Progress
Medium
Bill Filler
Canonical System Image backlog
webbrowser-app (Ubuntu)
Fix Released
Medium
Olivier Tilloy

Bug Description

This is reportedly waiting for the bottom edge component from unity8 to move to the UITK.

The less packages depend on private headers, the less maintenance overhead for moving to new Qt versions and the less chance of breakage.

Related branches

lp:~osomon/webbrowser-app/use-uitk-swipearea
system-apps-ci-bot: Needs Fixing (continuous-integration)
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 4899 lines (+8/-4580)
46 files modified
CMakeLists.txt (+0/-1)
debian/control (+0/-1)
src/app/CMakeLists.txt (+1/-3)
src/app/browserapplication.cpp (+0/-10)
src/app/unity8/CMakeLists.txt (+0/-1)
src/app/unity8/README (+0/-8)
src/app/unity8/libs/CMakeLists.txt (+0/-1)
src/app/unity8/libs/UbuntuGestures/CMakeLists.txt (+0/-36)
src/app/unity8/libs/UbuntuGestures/CandidateInactivityTimer.cpp (+0/-41)
src/app/unity8/libs/UbuntuGestures/CandidateInactivityTimer.h (+0/-49)
src/app/unity8/libs/UbuntuGestures/DebugHelpers.cpp (+0/-95)
src/app/unity8/libs/UbuntuGestures/DebugHelpers.h (+0/-31)
src/app/unity8/libs/UbuntuGestures/Pool.h (+0/-132)
src/app/unity8/libs/UbuntuGestures/Timer.cpp (+0/-109)
src/app/unity8/libs/UbuntuGestures/Timer.h (+0/-105)
src/app/unity8/libs/UbuntuGestures/TouchOwnershipEvent.cpp (+0/-35)
src/app/unity8/libs/UbuntuGestures/TouchOwnershipEvent.h (+0/-50)
src/app/unity8/libs/UbuntuGestures/TouchRegistry.cpp (+0/-500)
src/app/unity8/libs/UbuntuGestures/TouchRegistry.h (+0/-182)
src/app/unity8/libs/UbuntuGestures/UbuntuGesturesGlobal.h (+0/-23)
src/app/unity8/libs/UbuntuGestures/UnownedTouchEvent.cpp (+0/-39)
src/app/unity8/libs/UbuntuGestures/UnownedTouchEvent.h (+0/-45)
src/app/unity8/plugins/CMakeLists.txt (+0/-1)
src/app/unity8/plugins/Ubuntu/CMakeLists.txt (+0/-1)
src/app/unity8/plugins/Ubuntu/Gestures/AxisVelocityCalculator.cpp (+0/-149)
src/app/unity8/plugins/Ubuntu/Gestures/AxisVelocityCalculator.h (+0/-146)
src/app/unity8/plugins/Ubuntu/Gestures/CMakeLists.txt (+0/-40)
src/app/unity8/plugins/Ubuntu/Gestures/Damper.h (+0/-87)
src/app/unity8/plugins/Ubuntu/Gestures/Direction.cpp (+0/-36)
src/app/unity8/plugins/Ubuntu/Gestures/Direction.h (+0/-45)
src/app/unity8/plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+0/-886)
src/app/unity8/plugins/Ubuntu/Gestures/DirectionalDragArea.h (+0/-308)
src/app/unity8/plugins/Ubuntu/Gestures/Gestures.qmltypes (+0/-168)
src/app/unity8/plugins/Ubuntu/Gestures/PressedOutsideNotifier.cpp (+0/-119)
src/app/unity8/plugins/Ubuntu/Gestures/PressedOutsideNotifier.h (+0/-62)
src/app/unity8/plugins/Ubuntu/Gestures/TimeSource.cpp (+0/-49)
src/app/unity8/plugins/Ubuntu/Gestures/TimeSource.h (+0/-54)
src/app/unity8/plugins/Ubuntu/Gestures/TouchDispatcher.cpp (+0/-367)
src/app/unity8/plugins/Ubuntu/Gestures/TouchDispatcher.h (+0/-89)
src/app/unity8/plugins/Ubuntu/Gestures/TouchGate.cpp (+0/-253)
src/app/unity8/plugins/Ubuntu/Gestures/TouchGate.h (+0/-112)
src/app/unity8/plugins/Ubuntu/Gestures/UbuntuGesturesQmlGlobal.h (+0/-23)
src/app/unity8/plugins/Ubuntu/Gestures/plugin.cpp (+0/-39)
src/app/unity8/plugins/Ubuntu/Gestures/plugin.h (+0/-31)
src/app/unity8/plugins/Ubuntu/Gestures/qmldir (+0/-3)
src/app/webbrowser/BottomEdgeHandle.qml (+7/-15)
Timo Jyrinki (timo-jyrinki)
Changed in webbrowser-app (Ubuntu):
importance: Undecided → Medium
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: New → Triaged
Revision history for this message
Olivier Tilloy (osomon) wrote :

SwipeArea component has landed in UITK 1.3, this is now unblocked.

Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
status: Triaged → In Progress
Revision history for this message
Olivier Tilloy (osomon) wrote :

Note that the fix for bug #1537782 adds back a dependency on qtbase5-private-dev.

Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Bill Filler (bfiller)
milestone: none → 11
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
Olivier Tilloy (osomon) wrote :

The build dependency on qtdeclarative5-private-dev went away, but we still have a build dependency on qtbase5-private-dev, because of the fix for bug #1537782. So technically I don’t think we can consider this bug "fixed".
When we migrate to Qt 5.5 for touch images (will happen when we rebase on xenial), we can remove that dependency. Until then the dependency on private headers will remain.

Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: Fix Committed → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: 11 → backlog
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20160509.3-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20160509.3-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * Resync trunk.

  [ Olivier Tilloy ]
  * Fine-tune the custom memory-pressure handler, from data gathered on
    several devices. (LP: #1576639)
  * Update translation template.

 -- Olivier Tilloy <email address hidden> Mon, 09 May 2016 17:56:03 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.