[sdk] leading actions width is too small making it very difficult to press
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Zoltan Balogh | ||
Ubuntu UX |
Fix Released
|
Medium
|
Jamie Young | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Critical
|
Zsombor Egri |
Bug Description
Since a recent update to the ListItem leading actions in Ubuntu.Components 1.2, where the width of the action was clamped, the width is too small to press comfortably on a phone resulting in it missing 9 out of 10 tries. It affects the usability of the action and may be become a release blocker for apps that have recently switched over to the new list items.
Sample App
import QtQuick 2.4
import Ubuntu.Components 1.2
MainView {
application
width: units.gu(100)
height: units.gu(75)
Page {
title: "Swipe to Delete"
ListItem {
id: listItem
Label {
}
]
}
}
}
}
With trailing actions, tapping the trailingActions first causes the ListItem to jump/scroll all the way to the left instead of actually activating the action. Only a second tap actually activates them.
---
Visual design: desired outcome:
Please expand the width of the leading and trailing actions to 6gu (they're currently 5gu). The 2gu icon will be centred in this.
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
- Zoltan Balogh: Approve
-
Diff: 833 lines (+283/-158)12 files modifiedsrc/Ubuntu/Components/Themes/Ambiance/1.3/ListItemStyle.qml (+1/-1)
src/Ubuntu/Components/plugin/privates/listitemdragarea.cpp (+3/-2)
src/Ubuntu/Components/plugin/uclistitem.cpp (+88/-49)
src/Ubuntu/Components/plugin/uclistitem.h (+0/-1)
src/Ubuntu/Components/plugin/uclistitem_p.h (+3/-7)
src/Ubuntu/Components/plugin/ucviewitemsattached.cpp (+0/-64)
tests/resources/listitems/ListItemTest.qml (+7/-2)
tests/unit_x11/tst_components/ListItemTestCase.qml (+4/-0)
tests/unit_x11/tst_components/ListItemTestCase13.qml (+14/-0)
tests/unit_x11/tst_components/tst_listitem.qml (+14/-14)
tests/unit_x11/tst_components/tst_listitem13.qml (+13/-14)
tests/unit_x11/tst_components/tst_listitem_extras.qml (+136/-4)
Changed in ubuntu-ux: | |
assignee: | nobody → Jamie Young (jamiedawsonyoung) |
importance: | Undecided → Medium |
Changed in ubuntu-ux: | |
status: | Incomplete → Confirmed |
summary: |
- leading actions width is too small making it very difficult to press on - Nexus 4 (mako) + leading actions width is too small making it very difficult to press |
summary: |
- leading actions width is too small making it very difficult to press + [sdk] leading actions width is too small making it very difficult to + press |
description: | updated |
Changed in canonical-devices-system-image: | |
milestone: | none → ww40-2015 |
assignee: | nobody → Zoltan Balogh (bzoltan) |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → Fix Released |
Changed in canonical-devices-system-image: | |
status: | New → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Released → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
Hi, can we get a screenshot of this to see the issue. Thanks!