SIM PIN unlock dialog mis-titled opening from indicator
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Canonical System Image |
High
|
Alejandro J. Cura | ||
| | indicator-network (Ubuntu) |
High
|
Pete Woods | ||
Bug Description
Version: ubuntu-
Steps to reproduce:
* 2 SIMs in the device both PIN locked
* both SIMs connected to network
* indicator-network -> enable Flight Mode
* wait till disconnected
* indicator-network -> disable Flight Mode
* wait for indicator updated
Actual results:
- hit SIM 1 unlock button, dialog titled "Enter SIM 2 PIN"
note that dialog does acutally refer to SIM1 and will unlock it, hitting the Cancel "X" and then second attempt to unlock results in correct title
- hit SIM 2 unlock button, dialog titled "Enter SIM 1 PIN"
same behaviour as SIM1
Expected result:
- always show the correct title on the unlock dialog
Related branches
- PS Jenkins bot: Approve (continuous-integration) on 2015-08-03
- Indicator Applet Developers: Pending requested 2015-08-03
-
Diff: 2029 lines (+682/-363)25 files modifiedCMakeLists.txt (+0/-7)
debian/control (+0/-1)
src/indicator/CMakeLists.txt (+0/-1)
src/indicator/agent/PasswordMenu.cpp (+4/-1)
src/indicator/agent/SecretAgent.cpp (+8/-7)
src/indicator/agent/SecretAgent.h (+9/-4)
src/indicator/agent/SecretRequest.cpp (+15/-27)
src/indicator/agent/SecretRequest.h (+4/-3)
src/indicator/factory.cpp (+18/-2)
src/indicator/main.cpp (+8/-17)
src/indicator/nmofono/manager-impl.cpp (+3/-2)
src/indicator/nmofono/manager-impl.h (+6/-1)
src/indicator/sim-unlock-dialog.cpp (+7/-18)
src/indicator/sim-unlock-dialog.h (+2/-1)
src/notify-cpp/CMakeLists.txt (+4/-1)
src/notify-cpp/notification-manager.cpp (+76/-0)
src/notify-cpp/notification-manager.h (+67/-0)
src/notify-cpp/notification.cpp (+138/-61)
src/notify-cpp/notification.h (+43/-22)
src/notify-cpp/snapdecision/sim-unlock.cpp (+41/-29)
src/notify-cpp/snapdecision/sim-unlock.h (+4/-3)
src/qdbus-stubs/dbus-types.h (+6/-0)
tests/integration/indicator-network-test-base.h (+5/-1)
tests/integration/test-indicator.cpp (+210/-152)
tests/unit/secret-agent/test-secret-agent.cpp (+4/-2)
| Jonathan Cave (jocave) wrote : | #1 |
| Launchpad Janitor (janitor) wrote : | #2 |
Status changed to 'Confirmed' because the bug affects multiple users.
| Changed in indicator-network (Ubuntu): | |
| status: | New → Confirmed |
| Jean-Baptiste Lallement (jibel) wrote : | #3 |
Another test case from boot
TEST CASE:
Setup: Requires 2 SIM protected by a PIN code
1. Boot the DUT
2. When the prompt to unlock SIM1 is displayed, dismiss it
3. Verify that the prompt to unlock SIM2 is displayed and the title is SIM2
EXPECT RESULT
Second unlock dialog asks to unlock SIM2
ACTUAL RESULT
It prompts to unlock SIM1 again (but accepts the PIN of the second SIM)
| John McAleely (john.mcaleely) wrote : | #4 |
@pmgowan, this looks like it needs triage for the next ota, since it's also been raised by our OEM partners.
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Pat McGowan (pat-mcgowan) |
| importance: | Undecided → High |
| milestone: | none → ww24-2015 |
| status: | New → Confirmed |
| Changed in indicator-network (Ubuntu): | |
| assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
| importance: | Undecided → High |
| Pat McGowan (pat-mcgowan) wrote : | #5 |
need to reassign
| Changed in canonical-devices-system-image: | |
| milestone: | ww24-2015 → ww34-2015 |
| Changed in indicator-network (Ubuntu): | |
| assignee: | Antti Kaijanmäki (kaijanmaki) → Alejandro J. Cura (alecu) |
| Changed in indicator-network (Ubuntu): | |
| assignee: | Alejandro J. Cura (alecu) → Pete Woods (pete-woods) |
| Changed in canonical-devices-system-image: | |
| assignee: | Pat McGowan (pat-mcgowan) → Alejandro J. Cura (alecu) |
| Launchpad Janitor (janitor) wrote : | #6 |
This bug was fixed in the package indicator-network - 0.5.2+15.
---------------
indicator-network (0.5.2+
[ Pete Woods ]
* Fix SIM PIN unlock dialog mis-titled Move from libnotify to internal
notify-cpp (LP: #1449925)
-- CI Train Bot <email address hidden> Wed, 12 Aug 2015 13:48:34 +0000
| Changed in indicator-network (Ubuntu): | |
| status: | Confirmed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |

Version: ubuntu- touch/devel- proposed/ krillin. en r67 vegetahd
Less easy to trigger on vivid as you do not have unlock the SIM again after flight mode if the SIM is still in location.
Can still repro by moving a locked SIM from one slot to another whilst in flight mode though.