Notification LED stays on when no messages in notification center
Bug #1385331 reported by
John Lenton
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Thomas Strehl | ||
indicator-messages (Ubuntu) |
Fix Released
|
High
|
Ted Gould | ||
qmenumodel (Ubuntu) |
Fix Released
|
High
|
Nick Dedekind | ||
qmenumodel (Ubuntu RTM) |
Fix Released
|
Undecided
|
Michał Sawicz | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Nick Dedekind | ||
unity8 (Ubuntu RTM) |
Fix Released
|
High
|
Nick Dedekind |
Bug Description
Observed the notification LED staying on even though there were no notifications in the indicators and the notification icon was greyed out.
Related branches
lp:~nick-dedekind/unity8/lp1385331.led
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Albert Astals Cid (community): Approve
-
Diff: 2016 lines (+1124/-312)35 files modifieddebian/control (+3/-3)
plugins/Lights/Lights.cpp (+9/-24)
plugins/Unity/Indicators/CMakeLists.txt (+3/-1)
plugins/Unity/Indicators/Indicators.qmltypes (+18/-7)
plugins/Unity/Indicators/actionrootstate.cpp (+97/-0)
plugins/Unity/Indicators/actionrootstate.h (+55/-0)
plugins/Unity/Indicators/modelactionrootstate.cpp (+127/-0)
plugins/Unity/Indicators/modelactionrootstate.h (+61/-0)
plugins/Unity/Indicators/plugin.cpp (+4/-2)
plugins/Unity/Indicators/rootstateparser.cpp (+75/-142)
plugins/Unity/Indicators/rootstateparser.h (+20/-36)
qml/Greeter/Clock.qml (+1/-1)
qml/Panel/IndicatorItem.qml (+0/-8)
qml/Panel/Indicators/IndicatorBase.qml (+1/-1)
qml/Panel/Indicators/IndicatorsLight.qml (+19/-1)
qml/Panel/IndicatorsMenu.qml (+5/-0)
tests/mocks/CMakeLists.txt (+1/-0)
tests/mocks/Lights/CMakeLists.txt (+8/-0)
tests/mocks/Lights/Lights.cpp (+84/-0)
tests/mocks/Lights/Lights.h (+66/-0)
tests/mocks/Lights/Lights.qmltypes (+45/-0)
tests/mocks/Lights/plugin.cpp (+33/-0)
tests/mocks/Lights/plugin.h (+32/-0)
tests/mocks/Lights/qmldir (+3/-0)
tests/mocks/QMenuModel/CMakeLists.txt (+1/-0)
tests/mocks/QMenuModel/QDBusActionGroup.qml (+21/-68)
tests/mocks/QMenuModel/actiondata.h (+52/-0)
tests/mocks/QMenuModel/plugin.cpp (+10/-0)
tests/mocks/Unity/Indicators/ActionRootState.qml (+46/-0)
tests/mocks/Unity/Indicators/qmldir (+2/-1)
tests/plugins/Unity/Indicators/rootactionstatetest.cpp (+4/-4)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Panel/Indicators/tst_IndicatorsLight.qml (+129/-0)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+52/-1)
tests/qmltests/Wizard/tst_Wizard.qml (+36/-12)
lp:~nick-dedekind/qmenumodel/lp1385331.led
- Albert Astals Cid (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 117 lines (+38/-2)3 files modifieddebian/changelog (+6/-0)
libqmenumodel/src/qdbusactiongroup.cpp (+23/-2)
libqmenumodel/src/qdbusactiongroup.h (+9/-0)
lp:~nick-dedekind/unity8/rtm-1385331
- Michael Zanetti (community): Approve
- Michał Sawicz: Needs Fixing
-
Diff: 1841 lines (+1038/-301)33 files modifieddebian/control (+3/-3)
plugins/Lights/Lights.cpp (+9/-24)
plugins/Unity/Indicators/CMakeLists.txt (+3/-1)
plugins/Unity/Indicators/actionrootstate.cpp (+97/-0)
plugins/Unity/Indicators/actionrootstate.h (+55/-0)
plugins/Unity/Indicators/modelactionrootstate.cpp (+127/-0)
plugins/Unity/Indicators/modelactionrootstate.h (+61/-0)
plugins/Unity/Indicators/plugin.cpp (+4/-2)
plugins/Unity/Indicators/rootstateparser.cpp (+75/-142)
plugins/Unity/Indicators/rootstateparser.h (+20/-36)
qml/Greeter/Clock.qml (+1/-1)
qml/Panel/IndicatorItem.qml (+0/-8)
qml/Panel/Indicators/IndicatorBase.qml (+1/-1)
qml/Panel/Indicators/IndicatorsLight.qml (+19/-1)
qml/Panel/IndicatorsBar.qml (+29/-20)
qml/Panel/IndicatorsMenu.qml (+5/-0)
tests/mocks/CMakeLists.txt (+1/-0)
tests/mocks/Lights/CMakeLists.txt (+8/-0)
tests/mocks/Lights/Lights.cpp (+84/-0)
tests/mocks/Lights/Lights.h (+66/-0)
tests/mocks/Lights/plugin.cpp (+33/-0)
tests/mocks/Lights/plugin.h (+32/-0)
tests/mocks/Lights/qmldir (+3/-0)
tests/mocks/QMenuModel/CMakeLists.txt (+1/-0)
tests/mocks/QMenuModel/QDBusActionGroup.qml (+7/-57)
tests/mocks/QMenuModel/actiondata.h (+52/-0)
tests/mocks/QMenuModel/plugin.cpp (+10/-0)
tests/mocks/Unity/Indicators/ActionRootState.qml (+46/-0)
tests/mocks/Unity/Indicators/qmldir (+2/-1)
tests/plugins/Unity/Indicators/rootactionstatetest.cpp (+4/-4)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Panel/Indicators/tst_IndicatorsLight.qml (+129/-0)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+50/-0)
lp:~ted/indicator-messages/lp1385331-unescape-message-ids
- Lars Karlitski (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 123 lines (+46/-15)2 files modifiedsrc/im-application-list.c (+29/-15)
tests/manual (+17/-0)
summary: |
- if u8 crashes while you had a notification and the screen was off, then - the led can stay on. + Notification LED stays on when no messages in notification center |
description: | updated |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
Changed in unity8 (Ubuntu): | |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
importance: | Undecided → High |
milestone: | none → ww03-2015 |
status: | New → Confirmed |
Changed in unity8 (Ubuntu RTM): | |
status: | New → Triaged |
importance: | Undecided → Critical |
milestone: | none → 14.09-ota-2 |
importance: | Critical → High |
Changed in unity8 (Ubuntu): | |
importance: | Undecided → High |
Changed in unity8 (Ubuntu RTM): | |
status: | Triaged → In Progress |
assignee: | nobody → Michał Sawicz (saviq) |
Changed in qmenumodel (Ubuntu): | |
status: | New → Fix Released |
importance: | Undecided → High |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
Changed in qmenumodel (Ubuntu RTM): | |
status: | New → In Progress |
assignee: | nobody → Michał Sawicz (saviq) |
milestone: | none → 14.09-ota-2 |
Changed in unity8 (Ubuntu RTM): | |
status: | In Progress → Triaged |
Changed in qmenumodel (Ubuntu RTM): | |
status: | In Progress → Triaged |
assignee: | Michał Sawicz (saviq) → Nick Dedekind (nick-dedekind) |
Changed in unity8 (Ubuntu RTM): | |
assignee: | Michał Sawicz (saviq) → Nick Dedekind (nick-dedekind) |
Changed in qmenumodel (Ubuntu RTM): | |
assignee: | Nick Dedekind (nick-dedekind) → Michał Sawicz (saviq) |
status: | Triaged → In Progress |
Changed in unity8 (Ubuntu RTM): | |
status: | Triaged → In Progress |
Changed in canonical-devices-system-image: | |
milestone: | ww03-2015 → ww05-2015 |
Changed in unity8 (Ubuntu RTM): | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Released → Confirmed |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
milestone: | ww05-2015 → ww07-2015 |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Thomas Strehl (strehl-t) |
milestone: | ww07-2015 → ww09-2015 |
Changed in indicator-messages (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Ted Gould (ted) |
importance: | Undecided → High |
Changed in canonical-devices-system-image: | |
milestone: | ww09-2015 → ww11-2015 |
status: | In Progress → Fix Released |
To post a comment you must log in.
There is a possibility that if unity8 crashes while the light state is set, then it can keep that state if u8 comes back up with no notifications.
We need to decouple the usage from the lights plugin from the messaging indicator widget so that it will keep the lights state up to date.