Remove Author by regex gives errors

Bug #808308 reported by drMerry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Wishlist
Unassigned

Bug Description

I wanted to remove authors by using the regex replace .* with ""

I selected 114 books I wanted to apply this tweak on.

I got errors the author field can not be empty

calibre, version 0.8.9
ERROR: Zoeken/vervangen ongeldig: Het auteur-veld mag niet leeg zijn. Boek met titel The Ambassadors From Aurigel niet verwerkt

I do get this error for every book because there is no abort function.

Work-around: hold escape key, this will cause the update-process to catch it (by accident) so the complete process will quit

Related branches

Revision history for this message
Charles Haley (cbhaley) wrote :

What is the bug? A book cannot have an empty author.

Revision history for this message
drMerry (invullen) wrote :

The problem is that I used this function on 114 books.
I will get 114 times the message that a book can not have an empty author, without a button to abort the replace.

Because I held the esc I could quit the process but if someone does not use the esc to quit a screen or does not hold it for a longer time, they will get 114 error messages.

Revision history for this message
Charles Haley (cbhaley) wrote :

OK, you are looking for an enhancement: add a cancel button to that error dialog that cancels the S/R. Changing to wishlist.

Note that a cancel button will not cancel any that might successfully have been done before the error, and it will not cancel any other operations on the other two tabs.

Changed in calibre:
importance: Undecided → Wishlist
Revision history for this message
drMerry (invullen) wrote :

The function I'm looking for is something like:
"Abort further processing".

So it is something like cancel, but it should stop all further processing, also on other tabs.

Revision history for this message
Charles Haley (cbhaley) wrote :

Assuming I add the button (not yet decided), it will stop the search replace. It will not stop any other processing nor undo any processing that has already been done.

Revision history for this message
drMerry (invullen) wrote :

undo is not what I was thinking about, but I think a complete stop would be a good idea. What if edits are based on the search-replace result (to be)?

Revision history for this message
Charles Haley (cbhaley) wrote :

The error messages have been removed. Changing authors or title to an empty value now fills it in with calibre's default value for an empty book.

Changed in calibre:
status: New → Fix Committed
Revision history for this message
drMerry (invullen) wrote :

A good fix for this use-case I think.
Thank you.

Kovid Goyal (kovid)
Changed in calibre:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.