popularity-sort not affected by sub-cat scheme

[drMerry]

When sorting on rating or popularity, the sub-category sort is not used.
The used sort is always partitioned.

Selecting an other sub-sort does refresh the list, but no (visible) action is taken.
Expected: Do not show the option of sub-sorting when rating or popularity is selected
OR
use the selected option (this implies that there has to be an extra tweak on subsorting (e.g. show every number of books, or group books per decimal (1-10, 11-20, ...))

[Charles Haley (cbhaley)]

I assume that when you say 'sub-category sort', you mean using the first-letter subcategorization scheme.

I don't know what you mean exactly by "selecting another sub-sort".

One cannot categorize by first letter when sorting by something other than first letter. As I think you are saying, it automatically switches to 'partition'. Of course, it could as easily switched to 'disabled', but I didn't choose that.

Calibre must not change the selected categorization scheme, because users expect to go back to first letter when sort-by-name is chosen again. However, the user should be allowed to change it. I have changed calibre to not permit selecting 'first letter' when the sort is not by name. The 'first letter' option remains visible (and checked if was checked before changing the sort), but is disabled.

[drMerry (invullen)]

Thank you

"I assume that when you say 'sub-category sort', you mean using the first-letter subcategorization scheme."

Indeed

"I don't know what you mean exactly by "selecting another sub-sort"."

Selecting another subcategorization scheme.

I think the mentioned fix is what I ment.
But:
"Calibre must not change the selected categorization scheme, because users expect to go back to first letter when sort-by-name is chosen again."

Well, it depents.
The way it is implemented at the moment, you are right.
But I can think of antoher option:
There are 3 ways of sorting:

Partitioning
'first letter (variant)'
'Partitioning (variant)'

E.g.:
Partitioning:
90-100[100]
20-90 [100]
1-20 [100]
1 [100]
1 [80]

First letter (variant):
100 [80]
98 [2]
95 [16]
90 [92]
20 [15]
12 [7]
5 [8]
4 [2]
3 [8]
1 [250]

Partitioning (variant)
100-110 [80]
90-99 [110]
20-29 [15]
10-19 [7]
1-9 [268]

[Charles Haley (cbhaley)]

I have no interest in building an alternate to first-letter that organizes by count instead of the first letter, but I won't stand in the way if someone else wishes to do it.

[drMerry (invullen)]

If you can tell me where to look in the code, I will set it on my wishlist and take a look some day.

[Charles Haley (cbhaley)]

src/gui2/tag_browser/model.py method _create_node_tree() in the sub-function process_one_node().

[Kovid Goyal (kovid)]

Fixed in branch lp:calibre. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased