wishlist fixes to Sharing over the net Preferences page

[Capnm]

Two low-priority wishlist fixes to the Sharing over the net Preferences page:

1) If the saved search used as a restriction is deleted, the only way to clear the (now invalid) restriction is to first set the restriction to an existing saved search, then set the restriction to [blank].
It would be nice if it noticed the restriction was invalid and either cleared it, or offered to clear it.

2) Grey out the "Start Server" button when there are unapplied changes.
I keep trying to make changes, stop & restart the server, all without leaving the page. Even though I should know better, it seems so logical with the start button right there, ready to be clicked.

Thanks, and thanks for so quickly fixing the server to protect me from my own sloppiness re (1) above :-)

[Kovid Goyal (kovid)]

Regarding (2) when you click start server any changes you have made to
preferences are applied. So there is no need to grey out the button.

Re-assing to Charles for (1)

[Kovid Goyal (kovid)]

Changing the component for this bug.

 assignee cbhaley
 status triaged

[Capnm (mgbrown)]

Not for me -- unless I'm missing something ...

e.g.:
I have the server set to use the restriction author:=Mark Twain
I open the preferences page
Either the server is not started, or I stop the server
I change the restriction to author:=Douglas Adams
I click Start Server
The server starts with the restriction author:=Mark Twain
Befuddling me, since the screen clearly shows author:=Douglas Adams
I click Apply and get the Warning:Restart Needed
Which I momentarily ignore :) to observe that the server is still
running Mark Twain
So I head back to Preferences and curiously ... the Start button is
active, even though the server is running
I click Start and it restarts the server with Douglas Adams

Which almost makes sense, but differs from what you just said

At 09:12 PM 4/6/2011, you wrote:
>Regarding (2) when you click start server any changes you have made to
>preferences are applied. So there is no need to grey out the button.

[Kovid Goyal (kovid)]

Search restiction was one of a couple fo setting that were not applied, a
situation that has now been remedied.

[Charles Haley (cbhaley)]

Fix submitted

[Charles Haley (cbhaley)]

BTW: there is no real need to clear the content server search restriction. It will be ignored at content server start-up if set to a non-existent saved search.

It is worth noting that deleting the underlying search while the content server is running will not lead to Good Things (tm).

[Kovid Goyal (kovid)]

Fixed in branch lp:calibre. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased