Error when trying to jump to in-book result location if the displayed result sentence has conterpart in book that has ruby text

Bug #2071348 reported by 23452gdfg
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Unassigned

Bug Description

If the original text contains ruby text user cannot jump to the location from search page.
Jumping to results with no ruby text is working normally.

Revision history for this message
Kovid Goyal (kovid) wrote :

This is not worth the effort for me personally. If some one else wants to implement it, I will be happy to supply any needed guidance. If so, re-open the ticket and we can discuss it.

Changed in calibre:
status: New → Won't Fix
Revision history for this message
23452gdfg (fyudtyn53) wrote :

Can someone please fix this, after some hours of research I've concluded this is above my ability to fix.

https://github.com/kovidgoyal/calibre/commit/33a8d70a93c7a596313dc0bc7b08d3ad0ecaeb86?diff=unified&w=0

This seems to be the commit that caused it, from what I understand the error arises because when jumping the viewer tries to highlight the text from search result which has ruby removed, while the original book still has the text with ruby.
highlighting function needs to be passed the original text along with the cleaned text and try to highlight the original text instead of the cleaned text so this mismatch doesn't occur.(There might be cleaner ways to fix this)

Revision history for this message
Kovid Goyal (kovid) wrote :

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

Changed in calibre:
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.