Update default selection filter for manual format adds via GUI

Bug #1952562 reported by Jeff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Unassigned

Bug Description

When I select button “Add a format to this book” in the “Edit metadata” window, the default filter is always set to “Books”. If the user has set “Preferences” → “Adding Books” → “Automatic Adding” → “Automatically add files of all types (not just e-books)”, can the filter instead default to all file types? The general thought is that if the user has somehow indicated that he wishes to manage all file types in Calibre (such as via the auto add dialog above or some other means if more suitable), it is logical that he may wish to manually add all file types as well.

Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: New → Fix Released
Revision history for this message
Jeff (annoywife) wrote :

It appears that the filter still defaults to “Books” even when “Automatically add files of all types (not just e-books)” is checked. Let me know if I can provide any additional info here.

Revision history for this message
Kovid Goyal (kovid) wrote : Re: calibre bug 1952562

The filter will stay at all files if the last time the dialog was used
you selected a non-book file. Read the whats new page for details.

Revision history for this message
Jeff (annoywife) wrote :

Thanks. My understanding from the “What’s new” write-up is that if I set the filter to “All files” when I manually add a format, the filter should remain on “All files” the next time I manually add a format to any Calibre item. This is not what’s happening – the filter still defaults to “Books” every time.

Revision history for this message
Kovid Goyal (kovid) wrote :

Only if the file you are adding is not in the lsit of known book types.

Revision history for this message
Jeff (annoywife) wrote :

Here is what is happening right now: I pick an arbitrary item in my Calibre library, go to the “Edit Metadata” window, select the “Add Formats” button (which defaults to the “Books” filter), change the filter to “All files”, select an arbitrary JPG file and click “OK”, visually verify that the JPG format has been successfully added, then click “OK” one final time to go back to the main Calibre window. When I immediately follow the above steps again, the filter is set to “Books” as it always has been. What am I missing? Can I provide any further information/logs/etc. to assist?

Revision history for this message
Kovid Goyal (kovid) wrote :

The change was for the add books button in the main calibre interface
not add formats in the edit metadata window.

Revision history for this message
Kovid Goyal (kovid) wrote :

I have now added it for that dialog as well.

Revision history for this message
Jeff (annoywife) wrote :

Thanks, Kovid – I appreciate it.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers