Possible oversight in Book Details: Missing copy options on composite columns

Bug #1950033 reported by ownedbycats
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Unassigned

Bug Description

Calibre 5.31.1 (x64)

When right-clicking on a composite column link in book details, some of the copy options are missing.

Steps to replicate:

1. Have a composite text-based column, not shown as HTML. {identifiers:select(isbn)} works - I've also tested it on a tag-like column.
2. In book details, right-click on a clickable item from an inbuilt column (tags, authors, etc). Under copy, there's several additional options, such as copying the text or creating a search link.
3. Now right-click the composite column. The options are missing.

Thank you!

Revision history for this message
Kovid Goyal (kovid) wrote : Re: calibre bug 1950033

Yes, those extra actions use information present about the column that
is absent from a composite column, which is basically a string that is
the result of running an arbitrary computation. There is no way to know
how to construct a search or similar from it.

 status wontfix

Changed in calibre:
status: New → Won't Fix
Revision history for this message
ownedbycats (ownedbycats) wrote :

Could it be difficult to have "copy the text: [text]" at least? That's the reason I noticed the missing options. Thank you.

Revision history for this message
Charles Haley (cbhaley) wrote :

@kovid: I have an implementation that adds a context action to copy the value of the field when there are no other semantics.

Possible problem: some fields were not links so there was no way to identify the field name, for example numbers and dates. I solved that problem by creating a link type that when clicked copies the text to the clipboard. This means a simple click copies the text, and it also gives a handle for the context menu. Are you OK with this? If so then I will submit a PR for evaluation.

The first attachment shows the new "copy" link. The second shows the context menu.

Revision history for this message
Charles Haley (cbhaley) wrote :
Revision history for this message
Kovid Goyal (kovid) wrote :

It's OK by me, but maybe have the link do a search instead keep the copy action in the context menu.

Revision history for this message
Charles Haley (cbhaley) wrote :

I tried doing a search but was foiled by formatting in date and numeric columns. I will look at extracting the base information and not the formatted value when searching.

Charles Haley (cbhaley)
Changed in calibre:
status: Won't Fix → Fix Committed
Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.