In 5.25, "Remove unused CSS" tool options do not do what they say they do anymore

Bug #1939912 reported by john miller
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Unassigned

Bug Description

After updating to Calibre 5.25 Portable on Windows 8.1 I noticed that the "Remove unused CSS" tool in the Calibre Editor has several errors.

1. The checkbox "Merge CSS rules with identical properties" now does nothing.

2. The new checkbox "Remove unreferenced stylesheets" also merges CSS rules with identical properties.

Essentially, this makes it impossible to do either "merge CSS rules with identical properties" or "remove unreferenced stylesheets" separately. They can only be done together.

The following bugs seem to be side effects of the main bug described above:

3. The "Merge CSS rules with identical properties" and "Remove unreferenced stylesheets" checkboxes are now automatically enabled upon first opening of the tool in a newly opened editor. (Normal behavior is for all checkboxes to be unchecked upon first opening)

4. Checking the "Merge CSS rules with identical properties" checkbox will uncheck itself after running the tool once. (Normal behavior is for checked boxes to remain checked when the tool is opened again)

5. Checking the "Remove unreferenced stylesheets" checkbox will also check the "Merge CSS rules with identical properties" after running the tool once.

The other checkboxes seem to work normally.

Revision history for this message
john miller (feathy) wrote :
summary: - "Remove unused CSS" tool options do not do what they say they do anymore
+ In 5.25, "Remove unused CSS" tool options do not do what they say they
+ do anymore
Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments