Renaming fixed-value text columns in tag browser fails.

Bug #1900921 reported by ownedbycats
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
Charles Haley

Bug Description

Calibre 5.3 (x64), Windows 10 Home (x64)

Here is how I discovered the issue:

1. Have two fixed-value text columns named "Quickstart Guides" and "Reference Cards" Each of them had three books. I was in a virtual library.
2. Right-click "Quickstart Guides" in the tag browser, and rename it to "Quickstart Guides and Reference Cards."
3. Attempt to drag some books from "Reference Cards" onto the newly-renamed column.

Expected result: That it would change the columns.
Actual result: Nothing happened.

Further investigation showed that the column value hadn't updated in the "edit custom column" window.

Both "delete" and "delete in virtual library" were also available but I didn't test that.

Another oddity: I noticed that "Rename [column value] in Virtual Library" was also available. Same result with a silent fail, but if there's a way to fix it instead of just disabling the menu for fixed-values it may be something to take into account (e.g. would it append a new entry?)

Thank you!

Revision history for this message
ownedbycats (ownedbycats) wrote :
Revision history for this message
ownedbycats (ownedbycats) wrote :

Another point of note: I edited the column properly (merging the two values). Doing a bulk-edit informed me that there were invalid values that wouldn't show on the list. This indicates that the menu entries probably weren't supposed to be there in the first place.

Revision history for this message
ownedbycats (ownedbycats) wrote :

Still another point of note: An instance where the Tag Browser rename does come in useful is when renaming a fixed-value in the proper way (through the column edit dialog). Renaming the now-invalid value to the valid one moves all the books over without bumping into that bulk metadata error.

Revision history for this message
Kovid Goyal (kovid) wrote : Re: calibre bug 1900921

Changing the component for this bug.

 assignee cbhaley
 status triaged

Changed in calibre:
assignee: nobody → Charles Haley (cbhaley)
status: New → Triaged
Revision history for this message
Charles Haley (cbhaley) wrote :

Plus an enhancement: add an editor to change the list of permitted values.

Changed in calibre:
status: Triaged → Fix Committed
Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers