[Feature Request] Delete text highlight without confirmation box

Bug #1897415 reported by someguy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
Unassigned

Bug Description

I'm liking the highlight feature A LOT, but when I want to delete a highlight in an EPUB, there is a confirmation box that I have to click on as well.

Can you add an option somewhere so that it doesn't ask for confirmation everytime I want to remove highlighted text? It would save a lot of time/clicks. Note I think the default behavior of asking is fine, but there should be an option to turn it off.

5.0.1 Calibre, Windows 10

someguy (someguy76)
summary: - delete highlight without confirmation feature
+ [Feature Request] Delete text highlight without confirmation box
Revision history for this message
Kovid Goyal (kovid) wrote : Re: calibre bug 1897415

There is a checkbox on that dialog itself "Show this warning again" that
you can use. To be clear I am talking about deleting highlights from the
"Highlights" panel in the calibre E-book viewer.

 status invalid

Changed in calibre:
status: New → Invalid
Revision history for this message
someguy (someguy76) wrote :

Right, but what about when I select the highlighted area for deletion, not using the Highlights panel?

See screenshot.

Changed in calibre:
status: Invalid → Opinion
Revision history for this message
someguy (someguy76) wrote :

I'm looking for a super fast way to delete highlights without having to use the highlight panel. With that panel, it has all the highlights I've done throughout the book, finding and deleting it is cumbersome.

Usually I'm on the same page, highlight something, then quickly decide that I didn't need to highlight that because the information is not relevant. I'd like to double click the highlighted section and quickly hit the trash button without any prompt.

Also having the highlights panel constantly open (or opening it/closing it) is very distracting and annoying.

It might even be useful to add a shortcut for deletion? As in, double click on the highlighted text and hit the "Delete" key or something? Just a thought.

Revision history for this message
Kovid Goyal (kovid) wrote :

There are technical reasons why adding confirmation boxes for
"in-viewer" question dialogs is a lot of work, will look into it
someday, when I have time.

Revision history for this message
someguy (someguy76) wrote :

I see, ok sounds good.

BTW, I didn't quite understand what you wrote about adding "confirmation boxes for in-viewer question dialogs is a lot of work".

My thought is that you can add a setting in "Preferences-->Selection Behavior" that says "do not ask for confirmation on delete" or something like that. Checking off that checkbox will store that setting, then when a user does a delete you can check if that setting is true and by-pass the GUI code completely and call the code that would be called when you click ok (well, again, not doing any GUI stuff).

I dunno, I don't know anything about Python 3 though.

Revision history for this message
Kovid Goyal (kovid) wrote :

This isnt python. In viewer code runs inside a browser, in javascript.
The ebook-viewer is basically a browser.

Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: Opinion → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers