download metadata only keeps one book per source

Bug #1802293 reported by ssducf on 2018-11-08
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

As currently written, download metadata only keeps one book per source.

Could an option be added (in the configure metadata download dialog) to keep all books from sources?

Possibly this could default to on if only one source is selected...

This is not worth the effort for me personally. If some one else wants to implement it, I will be happy to supply any needed guidance. If so, re-open the ticket and we can discuss it.

 status wontfix

Changed in calibre:
status: New → Won't Fix
ssducf (ssd-ubu) wrote :

I traced this down to a single function and I think fixing this is just adding another term to the if. Unfortunately, I lost the bookmark and would have to redo the code trace to find it. Adding the preference to the dialog would be the hard part once I re-found the code that does this.

Guidance would be appreciated.

Kovid Goyal (kovid) wrote :

The code will likely be in sources/ look for merge_metadata
or similar.

As for adding the option, look in sources/ for existing options
and pick a similar one and search for it in the codebase to see how to
implement it.

ssducf (ssd-ubu) wrote :

I've tested this for both values of the checkbox, with one source and a handful of sources.
I haven't tested the gui portion.

This seems to work well.

Kovid Goyal (kovid) wrote :

OK, I'll take a look at it when I have a moment.

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers