Library Keyboard Shortcuts aren't disabled when location is device

[Jim Miller]

Steps to duplicate are:
- Plugin a device, wait for it to be read
- Select book(s) in library
- Switch to Device view
- Press keyboard shortcut key
- Action occurs on selected library book(s) as if viewing library.

I've observed this with:
'E' for Edit Metadata
'Ctrl-M' for Mark books
'D' for Send to device
'P' for Polish book
'C' for Convert
And a custom shortcut I added ('4') for Pick a random book

These and several other built-in actions have a location_selected() method that disables self.qaction and/or menu items. I confirmed that location_selected() is called, but it doesn't seem to disable keyboard shortcuts to the same actions.

My system details:

calibre 3.31 [64bit] embedded-python: True is64bit: True
Windows-10-10.0.17134-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.17134')
Python 2.7.12+
Windows: ('10', '10.0.17134', 'SP0', u'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeDRM (6, 6, 0) && Count Pages (1, 8, 2) && Manage Series (1, 2, 8) && Generate Cover (1, 5, 21) && View Manager (1, 5, 2) && Reading List (1, 6, 6) && Find Duplicates (1, 6, 3) && Webscription (1, 1, 0) && EpubMerge (2, 4, 0) && FictionDB (1, 0, 10) && Barnes & Noble (1, 2, 15) && Unplugged (1, 0, 0) && Modify ePub (1, 3, 13) && SmartEject (2, 1, 0) && Quality Check (1, 9, 11) && FanFicFare (3, 0, 2) && ColumnSum (2, 0, 0) && fanficauthors.net CSS Fix (0, 0, 2) && Favourites Menu (1, 0, 4) && EpubSplit (2, 5, 0) && Kindle 2, 3, 4, Touch, PaperWhite, Voyage Device Interface MBP Update Mod (1, 0, 0)

[Kovid Goyal (kovid)]

This is not worth the effort for me to fix. Basically you would need to
implement this for each action individually because of the way the
system works. Also it can sometimes be useful to operate on the main
list while viewing books on the device. The shortcuts allow you to do
that.

 status wontfix

[Jim Miller (retiefjimm)]

It's your prerogative, of course, to choose what you work on.

But does that mean you aren't interested if I fix it either?

Because I'll look into it if you'd accept a fix, but not if you're declaring it a feature you want to keep.

[Kovid Goyal (kovid)]

No, it's fine, I'm OK with changing it to not work when the device view is active.