Feature request - custom systray icon

Bug #1738518 reported by Mohammadreza Abdollahzadeh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Unassigned

Bug Description

currently calibre use "calibre-gui" for system tray icon, which is calibre main icon. if we change icon name to something like "calibre-tray", then we can have a dedicated icon for calibre system tray in various icon themes like "Papirus", so that icon could better match with other applications system tray icon which are monochrome. see attachment for difference between current calibre tray icon and other apps which have a dedicated monochrome icon in "Papirus" icon theme.

Revision history for this message
Mohammadreza Abdollahzadeh (morealaz) wrote :
Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: New → Fix Released
Revision history for this message
Mohammadreza Abdollahzadeh (morealaz) wrote :

thanks.

Revision history for this message
Mohammadreza Abdollahzadeh (morealaz) wrote :

I install github version of calibre and we add calibre-tray icon to papirus icon theme (https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/1015) but, tray icon still is the same as before (calibre-gui). I check calibre code and see these lines in /usr/lib/calibre/calibre/gui2/ui.py file:

if self.system_tray_icon is not None:
   self.system_tray_icon.setIcon(QIcon(I('lt.png', allow_user_override=False)))
   if not (iswindows or isosx):
       self.system_tray_icon.setIcon(QIcon.fromTheme('calibre-gui', self.system_tray_icon.icon()))

I think these lines must be changed!!!

Revision history for this message
Mohammadreza Abdollahzadeh (morealaz) wrote :

I change calibre-qui to calibre-tray in

self.system_tray_icon.setIcon(QIcon.fromTheme('calibre-gui', self.system_tray_icon.icon()))

and problem solved.

self.system_tray_icon.setIcon(QIcon.fromTheme('calibre-tray', self.system_tray_icon.icon()))

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.