links in comments served by calibre-server should have target="_blank"

Bug #1737644 reported by Alan Aversa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Unassigned

Bug Description

Links in the comments sections of books served by calibre-server, e.g., at

http://mysite.com/calibre#book_id=1423&library_id=MyLibrary&panel=book_details

should have a target="_blank" tag so that they load in a new window/tab instead of within the comments frame.

Alan Aversa (aversa)
description: updated
summary: - links in commentns served by calibre-server should have target="_blank"
+ links in comments served by calibre-server should have target="_blank"
description: updated
Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: New → Fix Released
Revision history for this message
Alan Aversa (aversa) wrote :

I'm still getting this issue even with your patch.

Also, <a href> tags in the comments' HTML that already contain target="_blank" don't work at all (they don't even load within the iframe).

Revision history for this message
Kovid Goyal (kovid) wrote : Re: calibre bug 1737644

You need to refresh in your browser, and/or clear the appcache internal
cache in your browser.

Revision history for this message
Alan Aversa (aversa) wrote :

I can confirm this works now in v3.14.0 (although I didn't refresh my browser, and/or clear the appcache internal cache…).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.