[enhancement] allow icon substitutions for yes/no

Bug #1721374 reported by Robin on 2017-10-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
Unassigned

Bug Description

I would like to be able to change the yes/no icons to my choice of icons. There are times when the yes/no would be better suited if there was a different icon. For example having a yes/no column to indicate if the book is on a device would be better if I could insert a "device" icon. A yes/no icon to indicate if the book was purchased at Amazon would be better enhanced if I cold insert an Amazon logo.

This function should be added to the choices when creating the column in the first place or be allowed to be added via edit if there is already a column and the user isn't willing to lose the current data.

Charles Haley (cbhaley) wrote :

@kovid: I am willing to change models.py to get icon(s) for decorated columns from a column icon rule if such a rule exists, otherwise fall back to the "standard" processing and icons. This would allow a user to override the yes/no icons on a column basis. The downside: today rules are ignored on decorated columns. After the change the rules will "mysteriously" become significant. I don't think this is a significant problem because rules already override the standard decorator for decorated text columns.

Kovid Goyal (kovid) wrote :

Sounds OK to me

Charles Haley (cbhaley) on 2017-10-05
Changed in calibre:
status: New → Fix Committed

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: Fix Committed → Fix Released
Robin (robin-ellwood) wrote :

:) Thanks!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers