Search ignoring HTML markup finds within <?xml directive and HTML comments

Bug #1651160 reported by Raúl Núñez de Arenas Coronado on 2016-12-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
Unassigned

Bug Description

First of all, Kovid, sorry for bothering you with so many bug reports in such a short timespan, I'm testing your ebook-editor as thoroughly as possible.

Calibre 2.74 64bit
Windows 10 Home 64 bit

Search ignoring HTML markup actually finds text within HTML comments (even though this may be by design) but also in the XML declaration (<?xml... ?>). Not a big deal, really, as there's usually not much text within those elements, but I don't think it's proper behaviour. Neither HTML comments nor XML declarations are HTML tags, that's true, but I think it's reasonable to think that users will expect Calibre editor to search only on the book text with using "Search ignoring HTML markup", not only ignoring HTML tags, but also comments and declarations.

For example, it would find the dash or the single quotation marks in the text below:
<?xml version='1.0' encoding='utf-8'?>

Thanks again for Calibre and for your time :)

This is not worth the effort for me personally. If some one else wants to implement it, I will be happy to supply any needed guidance. If so, re-open the ticket and we can discuss it.

 status wontfix

Changed in calibre:
status: New → Won't Fix

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: Won't Fix → Fix Released

> This is not worth the effort for me personally. If some one else wants
> to implement it, I will be happy to supply any needed guidance. If so,
> re-open the ticket and we can discuss it.
>
> status wontfix

I see you are up to your usual promises. :p

Thanks for the fix, Kovid!

An easy way to implement it occurred to me after my first post :)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers