paste ISBN button regular expression

Bug #1604956 reported by glachance on 2016-07-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
Unassigned

Bug Description

This button's (https://i.imgur.com/hU5O5Xx.png) regular expression needs a $ at the end (i think anyway).

If you paste 9783732511280IHaveAManCrushOnKovidGoyal it won't stop at 9783732511280 although it accepts it as valid and puts it in the identifiers list.

- (not important stuff - ramblings) -
I'm disproportionately happy to have found that bug (considering it's dare I even use the word "significance") because I have big plans for that button. I had not done anything because of the prospect of going through mountains of code to find it. I'll keep on eye on the commits on github and that is going to be my way in.

glachance (guillaumelachance) wrote :
glachance (guillaumelachance) wrote :

I just realized this is an email system - so i am effectively spamming your inbox. MEA-MEA culpa. Very sorry. I thought the comment section would be safe to try stuff. Won't happen again.

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: New → Fix Released
Kovid Goyal (kovid) wrote :

Incidentally, if you want to work on something in calibre and are daunted by the prospect of finding what part of the code it is in, just ask in the calibre development forum at mobileread.com -- lots of friendly people there.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments