Rename search creates a new one instead

[Jellby]

In the "Manage saved searches dialog", the "Rename the current search" button does not rename the current search, but create a copy of the (old) current search with a new name, where with "(old)" I mean that the copy doesn't contain unsaved changes one may have done to the current search.

By contrast, the "Add the new saved search" button creates a new empty saved search.

- Create a saved search. For example: "en", with "language:english".

- In the Manage saved searches dialog select "en".

- Write "de" in the blank name box.

- Click on the "+" button. An empty "de" search is created. (I would expect the new search to be created with the contents shown below.)

- Click on the "delete" button to remove the "de" search. Make sure "en" is again selected and "de" appears in the box.

- Modify the contents so that it is "language:german".

- Click on the "rename" button. A search "de" with "language:english" is created.

- Selecting the "en" search again shows "language:german". (I would expect the "en" search not to exist at all, since it was renamed)

So, not only the "en" search is not renamed, but the new one is created with the old contents and the new contents are applied to the old search. This is quite confusing, I think. If fixing the behaviour is not easy or worth the trouble, I suggest at least changing the wordings:

"Add the new saved search" -> "Create a new empty saved search"
"Rename the current search to what is in the box" -> "Create a copy of the current search with a new name"

[Kovid Goyal (kovid)]

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased