Delete tag from Tag Browser

Bug #1446318 reported by mihal.v on 2015-04-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
Charles Haley

Bug Description

It seems there is no way to delete tag at all from tag browser. There is no 'Delete' button or 'Delete' item in context menu. When I replace tag with nothing calibre offers to delete it but as a result I see following

calibre, version 2.25.0
ERROR: Unhandled exception: <b>TypeError</b>:QTableWidgetItem.setText(str): first argument of unbound method must have type 'QTableWidgetItem'

calibre 2.25 [64bit] isfrozen: True is64bit: True
Windows-8-6.2.9200 Windows ('64bit', 'WindowsPE')
('Windows', '8', '6.2.9200')
Python 2.7.9
Windows: ('8', '6.2.9200', '', 'Multiprocessor Free')
Successfully initialized third party plugins: Extract ISBN && Count Pages && Find Duplicates
Traceback (most recent call last):
  File "site-packages\calibre\gui2\dialogs\tag_list_editor.py", line 219, in finish_editing
  File "site-packages\calibre\gui2\dialogs\tag_list_editor.py", line 44, in setText
TypeError: QTableWidgetItem.setText(str): first argument of unbound method must have type 'QTableWidgetItem'

Charles Haley (cbhaley) wrote :

You are not talking about the tag browser but are instead talking about the "Manage Tags" dialog. In that dialog, when you set a tag to nothing you get a message "Item is blank: An item cannot be set to nothing. Delete it instead", which is not an "offer to delete". There is a "Delete" icon (the green recycle arrows) on that dialog that deletes the current tag, so there is a way to delete a tag in Manage Tags.

I agree that it shouldn't throw the error when you empty the value and it produces the "You can't do that" message. I will fix that. It won't delete the tag.

Changed in calibre:
assignee: nobody → Charles Haley (cbhaley)
status: New → Triaged
status: Triaged → Fix Committed

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers