Portable install crashes on low disk space

[Jan]

I tried to update from portable 1.37 and the installer crashed multiple times (1.38 and 1.39).After the crashs I noticed that only 100 MB were left on the portable disk. I did some cleanup and after having more space the installer ran without a problem.

[Kovid Goyal (kovid)]

WHat do you mean by crashed? When I try to run the portable installer
choosing a destination directory on a drive with not enough space, I get
an error message that reads:

"Failed to write uncompressed data to temp file. Disk Full"

The details of the error message will differ depending on exactly what
the shortfall is, thereby, influencing where in the process it fails,
but you should always get an error message, is that not what you see?

 status incomplete

[Jan (silentguy)]

I got a proper windows app crash.. The typical "has stopped working"...

I did some experimenting and I can get some different results depending on the free space. With 318 MB it installs fine. With 100 MB it shows the error message you mentioned and then causes a "has stopped working" and with values around 200-250MB is just shows a "has stopped working".

From what I see, it checks if the installation would fit on the drive (~150MB), if not it shows the "Disk Full" error message. Regardless it still starts writing temporary and permanent files, which take up at least 250MB. If this fails, it just crashes ungracefully, leaving behind it's files (free space 4 kb).

It would probably be best to increase the amount checked for to generate the error message and also have it quit (and clean up?) after the error message.

Oh, and here is the crash sig, but it's german, sorry.

Problemsignatur:
  Problemereignisname: APPCRASH
  Anwendungsname: calibre-portable-installer-1.39.0.exe
  Anwendungsversion: 1.39.0.0
  Anwendungszeitstempel: 538706ca
  Fehlermodulname: calibre-portable-installer-1.39.0.exe
  Fehlermodulversion: 1.39.0.0
  Fehlermodulzeitstempel: 538706ca
  Ausnahmecode: c0000005
  Ausnahmeoffset: 000115d3
  Betriebsystemversion: 6.1.7601.2.1.0.256.4
  Gebietsschema-ID: 1031
  Zusatzinformation 1: 0a9e
  Zusatzinformation 2: 0a9e372d3b4ad19135b953a78882e789
  Zusatzinformation 3: 0a9e
  Zusatzinformation 4: 0a9e372d3b4ad19135b953a78882e789

Lesen Sie unsere Datenschutzbestimmungen online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0407

Wenn die Onlinedatenschutzbestimmungen nicht verfügbar sind, lesen Sie unsere Datenschutzbestimmungen offline:
  C:\Windows\system32\de-DE\erofflps.txt

[Kovid Goyal (kovid)]

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased