Update Orizon driver

Bug #1265225 reported by Jellby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Unassigned

Bug Description

The driver for Bookeen's Cybook Orizon driver creates a thumbnail with the wrong format and filename, the "t2b" format is used in the Gen3 reader, but not in the Orizon.

As suggested in this thread: http://www.mobileread.com/forums/showthread.php?t=230374 I've created a patch that, I hope, fixes this, and it also implements two other changes, so the list of changes is:

1. Create thumbnails with the "new" t4b format (.thn extension).
2. Remove mobi and prc from the default list of supported formats.
3. Add a configuration option for the folder to send books to in the memory card.

I've done some quick tests and all seems to be working, but especially with #3 I may have done something wrong.

Revision history for this message
Kovid Goyal (kovid) wrote :

Did you forget to attach the patch?

Changed in calibre:
status: New → Incomplete
Revision history for this message
Jellby (jellby) wrote :

Hm... I did choose the file and fill up the info for the attachment, maybe I had to add some confirmation...

Attaching again with this comment.

Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: Incomplete → Fix Released
Revision history for this message
Kovid Goyal (kovid) wrote : Re: calibre bug 1265225

I have merged, chaning the driver to scan all folders on the card for
books, and also making the code in t4b python 3 friendly. Please check
that I did not break anything.

Revision history for this message
Jellby (jellby) wrote :

Thanks, I'll ty... and I see now that I forgot to add the default thumbnail in t4b.

You may want to update the code in t2b too.

Revision history for this message
Kovid Goyal (kovid) wrote :

I only insist that new code added to calibre is py3 compatible, migrating old code is too much work -- something I'll only undertake if I actually decide to migrate to py3.

Revision history for this message
Jellby (jellby) wrote :

Here is another patch, with the missing default thumbnail.

Revision history for this message
Kovid Goyal (kovid) wrote :

Merged.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.