[Glitch] Case change in library list cell

Bug #1251768 reported by Better Red on 2013-11-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
Charles Haley

Bug Description

Windows 7-SP1, Calibre 1.11

If I mistype a value in a custom column Name cell - eg "glenda Jackson" I can't correct the casing in the cell, either by overtyping the 'g' with 'G' or by highlighting the "glenda Jackson" and changing the case via the context menu facility.

I can correct the error either via the Rename "glenda Jackson" context menu item in the Tag Browser. or via the custom columns panel in the Edit Metadata panel, I find the former easier. But I'd prefer to be able to correct the mistake 'in situ' because I normally spot the mistake immediately after making it :)

Not sure if this only applies to name cells

BR

Changing the component for this bug.

 assignee cbhaley
 status triaged

Kovid Goyal (kovid) wrote :

@Charles: From the description, it sounds like the delegates for custom
columns are not using the new completers from gui2/complete2.py

Changed in calibre:
assignee: nobody → Charles Haley (cbhaley)
status: New → Triaged
Charles Haley (cbhaley) wrote :

@Kovid: I will look at which completer it uses, and also whether "allow_case_change" is implemented and allowed.

That said, I am not convinced that changing this is a good idea. If changed, then any accidental case change will be applied to all books with that name, also changing last_mod. I remember the recent complaints about that happening with tags. Are you sure case changes should win?

Kovid Goyal (kovid) wrote :

To me, preventing the user from performing an action, because it *might*
not be what the user intended is not the right way to go. The builtin
fields all allow case changes, IIRC.

Better Red (urbanetiger) wrote :

Agree with Kovid's last comment.

if I can mistype something into a built-in column library list cell and have it cascade through the library, and then correct my mistyping in another cell in the same column and have that cascade through the library then why not the same for custom columns.

And it is only Case changes that don't stick when corrected. I can mistype Gettysburg into a Location custom column as 'Gettysberg' and go back into the cell and correct it, but I can't correct 'gettysburg' in the same way.

I've mistyped 'penguin' as the publisher and then corrected it to 'Penguin' a couple of times - by deleting the 'p' and typing a 'P'.

I don't make any use of the last_modified timestamp.

br

Charles Haley (cbhaley) wrote :

No text custom column allowed case change. Now all do.

Changed in calibre:
status: Triaged → Fix Committed

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: Fix Committed → Fix Released
Better Red (urbanetiger) wrote :

Thanks guys

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers