Htmlz inline css doesn't single quote fonts & thus destroys html

Bug #1239527 reported by Slobberchopz on 2013-10-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Undecided
John Schember

Bug Description

Calibre 1.4.0 32 bit, Windows 7 Home Premium 64 bit

The css attribute 'font-family' often uses double quotes around a font, for example: "Times New Roman". This is perfectly OK in the stylesheet, but when used inline, it must be switched to single quotes ('Times New Roman') otherwise it will break up the style-attribute in wrong places, resulting in invalid html (style=" "Times New Roman", serif"). If any properties follow the font-family property, they will then generally be ignored by parsers and rendering engines. [For more information: http://www.w3.org/TR/CSS2/fonts.html#font-family-prop]

When Htmlz conversion is set to 'inline' for all css, and a font-family property is moved from the stylesheet to inline, calibre doesn't check and convert double quotes to single quotes, resulting in invalid Html.

Thanks!

Changing the component for this bug.

 assignee user-none
 status triaged

Changed in calibre:
assignee: nobody → John Schember (user-none)
status: New → Triaged
Changed in calibre:
status: Triaged → Fix Committed
Kovid Goyal (kovid) on 2013-10-15
Changed in calibre:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers