Feature Request: Don't "destroy" undo/ctrl-z and redo/ctrl-y for the fields, after metadata download

Bug #1223367 reported by Melanie Hotz on 2013-09-10
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
calibre
Undecided
Unassigned

Bug Description

edit metadata individually:

in each field you can use the undo/ctrl-z and redo/ctrl-y feature.
But after downloading the metadata you are not able to make an undo to the old value.

I would like to use undo/ctrl-z and redo/ctrl-y for the fields, after metadata download

This is not worth the effort for me personally. If some one else wants to implement it, I will be happy to supply any needed guidance. If so, re-open the ticket and we can discuss it.

 status wontfix

Changed in calibre:
status: New → Won't Fix
Anselm (anselm2004) wrote :

This would be interesting for me too.

I did some research and i think the solution can be done, if "setText" is avoided, and "insert" is used instead.

This is the solution done in

Bug #840448 “Various bugs for past isbn button” : Bugs : calibre
https://bugs.launchpad.net/calibre/+bug/840448

see calibre/src/calibre/gui2/metadata/basic_widgets.py at master · kovidgoyal/calibre
https://github.com/kovidgoyal/calibre/blob/master/src/calibre/gui2/metadata/basic_widgets.py#L1314

            # Use clear + insert instead of setText so that undo works
            self.clear()
            self.insert(txt.strip())
            self.setCursorPosition(0)

It would be very nice, if you can do it in this way for the other fields. This should make it possible to do an undo after downloading the metadata.

Fixed in branch master. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers