Last modified timestamp not changed when deleting value in tag browser

[David Forrester]

While doing some testing of the Kobo driver I found a problem that I would like to check.

The Kobo driver uses one or more columns to define book shelves on device. For my testing, I used a tag-like column and gave all books in the library the same value. Plus I gave most another value depending on the format.

A part of the testing, I removed the value for all the books. When I synced with the device, the shelves were not removed. After a lot of messing around (and swearing), I discovered the problem was that the last modified timestamp hadn't been updated for the books. And it was related to how I removed the value from the books.

The method I used was to find the column in the tag browse, expand it, select the value, right click on it and select delete. This worked fine to remove the value, but the last modified timestamp on the books was not updated.

When I removed the value using the metadata edit screen, either one book at a time or in bulk, the timestamp was updated.

[Kovid Goyal (kovid)]

@Charles: I notice that delete_custom_using_id() does not dirty the references books, unlike the equivalent functions for the standard metadata fields. I assume this is an oversight?

I'm assigning this bug to you, but if you dont feel like fixing it, let me know and I will add the dirtying code.

[Charles Haley (cbhaley)]

Added the code to update the timestamp when values are deleted from custom columns. While there I checked the other code paths, and they seem to be fine.

[Kovid Goyal (kovid)]

Fixed in branch lp:calibre. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased