Comment 6 for bug 1385907

I see 2 problems:
- in cairo_dock_remove_all_icons_from_applet(), the sub-dock is not
updated; this is an optimisation (window resize), because in most case the
applet will load another list of Icons inside the container; however, it
forces the applet to load an empty icons list, which is probably not
intuitive (and as we see here, most of the time it will be forgotten ^^ )
- in the applet, the monitor on the previous folder is not removed, because
myConfig.cDirPath has already changed; so the applet should keep its value
in myData

2014-10-28 4:55 GMT+01:00 Brian <email address hidden>:

> nick - I agree that it would make sense to have the 'Open the
> configuration ...' pop up when the path is empty.
>
> I have been looking at the code trying to see why it does not since the
> reloading of the configuration brings that popup message.
>
> I haven't updated to the latest code yet but it looks like the reason is
> in how the code checks for the null path when the icon is clicked. If
> the icon list is null clicking the icon will pop up that message but if
> the icon list is not null (meaning it had data at some time) then
> clicking the icon will not pop up that message.
>
> If the code for the Folders applet has not changed much for version
> 3.4.0 then one solution may be to change a line in the file applet-
> notifications.c (I haven't tested this so I am not 100% sure)
>
> the line:
> else if (CD_APPLET_MY_ICONS_LIST == NULL)
> change to:
> else if (CD_APPLET_MY_ICONS_LIST == NULL || myConfig.cDirPath == NULL)
>
> This code is within the CD_APPLET_ON_CLICK_BEGIN section.
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Devs, which is subscribed to Cairo-Dock Plug-ins.
> https://bugs.launchpad.net/bugs/1385907
>
> Title:
> Folders Applet - panel not resizing on deletion of path
>
> Status in Cairo-Dock: Plug-ins:
> New
>
> Bug description:
>
> ============================================================================
> Cairo-Dock version : 3.4.0
> Compiled date : Oct 17 2014 09:05:35
> Built with GTK : 3.14
> Running with OpenGL: 1
>
> ============================================================================
> This issue was found in KDE and it occurs regardless of whether KDE
> Integration is enabled.
>
> STEPS TO RE-CREATE
> 1. Configure the Folders Applet by adding a path with a number of
> different folders.
> 2. Click on Folders Applet - panel should be sized according to number
> of folders.
> 3. Configure the Folders Applet and blank out the path previously added
> - then click Apply.
> 4. Click on Folders Applet - large blank panel is displayed to user (see
> screenshot) - expected behaviour is that no panel should be displayed to
> user.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cairo-dock-plug-ins/+bug/1385907/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team
> More help : https://help.launchpad.net/ListHelp
>