Fix border shape for rounded rectangle dock

Bug #1306557 reported by Nikita Zlobin on 2014-04-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cairo-Dock Core
Undecided
Fabounet

Bug Description

Hello.
I'm currently using cairo-dock in cairo mode, since in gl mode look sometimes is coarse. There are two problems:
1. When only top corners are rounded, in 3d rect mode sides become tilted out of panel.
2. In cairo mode visible sides angle is independent of panel positioning, unlike icon separators. Only tilting angle is considered, and this makes look very inconsistent in some cases.

I guess, it is problem of drawing way. My proposal is to draw initially untilted, than only if selected view is some kind of 3d - deform it using cairo features. Initial drawing should include not only dock border and its filling, but all elements, affecting its form - such as icon separators. I guess, cairo has necessary 2d transformations to do it not worse than gl.
In addition - it would be better to place corners always in pixel's center at least in quiet mode (without animation), while in animation - without rounding (same is true for gl mode).
----
Yet, in gl mode - i found reason, why lines look coarse sometimes. Looks like feature of current way. Lines with any visible thickness are rectangles, and they are used to form arcs, what is very critical for rounded corners. They are enough good with opaque borders, but if transparent - look is horrible. My proposal is to consider lines are areas, which should be filled.

I propose this way:
1. Draw outer shape, for which only outer border is defined (no need for hole for panel itself).
2. Draw inner shape above.
- both shapes are opaque.
3. Create second drawing in same way, but for alpha channel, than apply it.

I understand it is complicated, but i's for higher quality. Optionally there could be user option to switch between fast (current) and proposed careful way.

Matthieu Baerts (matttbe) wrote :

Hello and thank you for this bug report! (and sorry for this very very long delay!)

Which version of the dock are you using? And what's your GNU/Linux or BSD distribution and its version?

> When only top corners are rounded, in 3d rect mode sides become tilted out of panel.

I already had this bug I think but I no longer only use the Cairo backend...

> They are enough good with opaque borders, but if transparent - look is horrible

Yes I understand and I agree with you!

@fabounet: can you have a look to this bug? :-)

Changed in cairo-dock-core:
status: New → Incomplete
assignee: nobody → Fabounet (fabounet03)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers