Cable

Links do not always work

Bug #1202296 reported by Auroral Xylon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cable
Fix Released
Medium
Julien Spautz
Cable 0.1

Bug Description

Links stop after special characters such as '#' and '!'. To reproduce this, copy paste: http://elementaryos.org/#!elementaryrocks into cable. The 'elementaryrocks' is not linked.

Related branches

lp:~julien-spautz/cable/model-view
Eduard Gotwig (community): Needs Fixing
Diff: 8665 lines (+4717/-2866)
50 files modified
CMakeLists.txt (+40/-13)
README.rst (+121/-0)
data/org.pantheon.cable.gschema.xml (+0/-5)
po/cable.pot (+138/-143)
po/fr.po (+173/-142)
src/Cable.vala (+63/-26)
src/Controller/Channel.vala (+170/-0)
src/Controller/Server.vala (+65/-0)
src/Controller/Window.vala (+163/-0)
src/Dialogs/JoinChannel.vala (+12/-11)
src/Dialogs/ManageIdentity.vala (+46/-19)
src/Dialogs/ManageNetwork.vala (+18/-11)
src/Dialogs/Preferences.vala (+23/-30)
src/Irc/Channel.vala (+322/-0)
src/Irc/Client.vala (+59/-0)
src/Irc/Irc.vala (+43/-0)
src/Irc/Maki.vala (+278/-0)
src/Irc/Server.vala (+731/-0)
src/Services/Client.vala (+0/-278)
src/Services/Identity.vala (+0/-124)
src/Services/Launcher.vala (+66/-0)
src/Services/Network.vala (+0/-104)
src/Services/Notification.vala (+48/-0)
src/Services/Settings.vala (+0/-143)
src/Services/Unity.vala (+0/-64)
src/Settings/Preferences.vala (+39/-0)
src/Settings/Settings.vala (+33/-0)
src/Tests/Tests.vala (+13/-0)
src/Tests/Utils.vala (+101/-0)
src/Utils.vala (+0/-69)
src/Utils/AutoScrolled.vala (+44/-0)
src/Utils/EmbeddedAlert.vala (+424/-0)
src/Utils/Identity.vala (+201/-0)
src/Utils/Network.vala (+146/-0)
src/Utils/Utils.vala (+65/-0)
src/View/Channel.vala (+38/-0)
src/View/Server.vala (+69/-0)
src/View/Window.vala (+100/-0)
src/Widgets/Channel.vala (+82/-73)
src/Widgets/ChatDisplay.vala (+125/-10)
src/Widgets/Room.vala (+232/-283)
src/Widgets/Server.vala (+64/-338)
src/Widgets/ServerList.vala (+0/-104)
src/Widgets/TopicBar.vala (+72/-0)
src/Widgets/User.vala (+4/-84)
src/Widgets/Welcome.vala (+23/-22)
src/Widgets/Window.vala (+263/-0)
src/Window.vala (+0/-317)
vapi/libwnck-3.0.deps (+0/-7)
vapi/libwnck-3.0.vapi (+0/-446)
Julien Spautz (julien-spautz)
Changed in cable:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Julien Spautz (julien-spautz) wrote :

For a really, REALLY, REALLY complete regex, there is the one Abigail posted on comp.lang.perl.misc (it's quite long):

http://www.perlmonks.org/?node_id=533586

Probably takes 5 years to match, but I'll try to implement it just for fun :P

Revision history for this message
Julien Spautz (julien-spautz) wrote :

Compilation failed: 4756 error(s), 0 warning(s)

Fuck this.

Revision history for this message
Julien Spautz (julien-spautz) wrote :

I hacked our current regex and I got it working more or less.

Changed in cable:
status: Confirmed → In Progress
assignee: nobody → Julien Spautz (julien-spautz)
Revision history for this message
Julien Spautz (julien-spautz) wrote :

Should be fixed in rev 136

Changed in cable:
status: In Progress → Fix Released
milestone: none → 0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.