bzr shell crashes with single quote command

Bug #231020 reported by David Cournapeau
4
Affects Status Importance Assigned to Milestone
BzrTools
Fix Released
Undecided
Unassigned

Bug Description

Here is what I get with bzr and bzrtools to 1.4:

bzr shell
> '

bzr: ERROR: exceptions.ValueError: No closing quotation

Traceback (most recent call last):
  File "/home/david/local/stow/bzr-1.4/lib/python2.5/site-packages/bzrlib/commands.py", line 846, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/home/david/local/stow/bzr-1.4/lib/python2.5/site-packages/bzrlib/commands.py", line 802, in run_bzr
    ret = run(*run_argv)
  File "/home/david/local/stow/bzrtools-1.4/lib/python2.5/site-packages/bzrlib/plugins/bzrtools/command.py", line 13, in run_argv_aliases
    commands.Command.run_argv_aliases(self, argv, alias_argv)
  File "/home/david/local/stow/bzr-1.4/lib/python2.5/site-packages/bzrlib/commands.py", line 504, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/david/local/stow/bzrtools-1.4/lib/python2.5/site-packages/bzrlib/plugins/bzrtools/__init__.py", line 383, in run
    return shell.run_shell()
  File "/home/david/local/stow/bzrtools-1.4/lib/python2.5/site-packages/bzrlib/plugins/bzrtools/shell.py", line 227, in run_shell
    prompt.cmdloop()
  File "cmd.py", line 142, in cmdloop
    stop = self.onecmd(line)
  File "cmd.py", line 213, in onecmd
    return self.default(line)
  File "/home/david/local/stow/bzrtools-1.4/lib/python2.5/site-packages/bzrlib/plugins/bzrtools/shell.py", line 171, in default
    args = shlex.split(line)
  File "shlex.py", line 279, in split
    return list(lex)
  File "shlex.py", line 269, in next
    token = self.get_token()
  File "shlex.py", line 96, in get_token
    raw = self.read_token()
  File "shlex.py", line 172, in read_token
    raise ValueError, "No closing quotation"
ValueError: No closing quotation

bzr 1.4 on python 2.5.1 (linux2)
arguments: ['/home/david/local/bin/bzr', 'shell']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bzrtools /home/david/local/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.4.0]
  fastimport /home/david/.bazaar/plugins/fastimport [unknown]
  gnulog /home/david/.bazaar/plugins/gnulog.py [unknown]
  gtk /home/david/.bazaar/plugins/gtk [0.93.0]
  launchpad /home/david/local/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  multiparent /usr/lib/python2.5/site-packages/bzrlib/plugins/multiparent.py [unknown]
  qbzr /home/david/.bazaar/plugins/qbzr [0.8.0dev0]
  svn /home/david/local/lib/python2.5/site-packages/bzrlib/plugins/svn [0.4.9dev0]
  usertest /home/david/.bazaar/plugins/usertest [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

/--------------------------------------------- mdageek ------------------------------------------/
Occured in the windows release as well: Bazaar (bzr) 1.7, Python interpreter: 2.5.2
Seems like the limit of argument length is about 32224 bytes. When trying to add a LOT of files, commit fails. (In the status message, filenames get truncated at the above mentioned number of characters.) Revert also fails for the same reason.

mdageek (mdageek)
description: updated
Jelmer Vernooij (jelmer)
Changed in bzrtools:
status: New → Fix Committed
Aaron Bentley (abentley)
Changed in bzrtools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.