post commit when using bzr as central repos fail

Bug #336535 reported by Luke Miller on 2009-03-02
2
Affects Status Importance Assigned to Milestone
bzrbuildbot
Low
Unassigned

Bug Description

The reason it failed is probably due to me, but the failure has exposed an error in the code.

  File "/usr/lib/python2.5/site-packages/Twisted-8.2.0-py2.5-linux-i686.egg/twisted/python/threadpool.py", line 210, in _worker
    result = context.call(ctx, function, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/Twisted-8.2.0-py2.5-linux-i686.egg/twisted/python/context.py", line 59, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib/python2.5/site-packages/Twisted-8.2.0-py2.5-linux-i686.egg/twisted/python/context.py", line 37, in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.5/site-packages/bzrbuildbot/hook.py", line 88, in _putResultInDeferred
    f = failure.Failure()
exceptions.NameError: global name 'failure' is not defined

The code in question is in hook.py:

There is no variable named "failure" and no import named "failure" in that module.

I assume that the except code is vary rarely triggered so this hasn't been seen before.

Regards,
Luke

Luke Miller (dodgyville) wrote :

Adding:

from twisted.python import failure

fixes the problem.

Regards,
Luke Miller

Changed in bzrbuildbot:
status: New → Triaged
importance: Undecided → Low
tags: added: buildbot trivial
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers