Comment 18 for bug 710410

Revision history for this message
Pat Tressel (ptressel) wrote : Re: [Bug 710410] Re: "Parsing failed" on uncommit if contents of commit message are nonstandard

> ... if it's also in the repository, might need to deal w/ it there, at
>> least to prevent it from being brought back into branch.conf as
>> un-escaped/un-encoded/not-stored-as-file text by an uncommit.
>>
>
> As I understand it, the copy in branch.conf is only kept there temporarily
> to remember what the last commit message was, so that the commit command can
> offer the same message when re-committing an uncommitted revision, for
> example. It has no relation to how the commit message is actually stored in
> the branch revision data.
>

So, an uncommit does not bring back the message from the (now) head revision
into branch.conf? The point was, if a message can get brought back into
branch.conf from the repository, but it's stored as verbatim original text
in the repository, you may need to add the same protection on that means of
inserting text into branch.conf as you would against the user inserting that
text with bzr commit -F, or, alternatively, support storing messages in the
repository in escaped/encoded/file-pointer format.

-- Pat