Logic to copy branch options (branch.conf) should be in core

Bug #97397 reported by Jelmer Vernooij
4
Affects Status Importance Assigned to Milestone
Bazaar
Incomplete
Wishlist
Unassigned

Bug Description

  affects /products/bzr-submit
  affects /products/bzr

bzr-submit currently wraps all the commands that involve copying
revisions (branch, pull, push) and adds functionality that copies
branch.conf.

This sort of functionality should be in Bazaar core rather than a
plugin.

--
Jelmer Vernooij <email address hidden> / Jabber: <email address hidden>
http://samba.org/~jelmer/

Revision history for this message
Hermann Kraus (c3po) wrote :

I'll add this as soon as the functionality is in bzr-core. Please update this bugreport then, so I don't miss the change!

Changed in bzr-submit:
assignee: nobody → c3po
importance: Undecided → Wishlist
status: Unconfirmed → Confirmed
Revision history for this message
John A Meinel (jameinel) wrote :

Is this still necessary? It seems like "bzr send" has mostly taken over the functionality of 'bzr submit'.

Also, it isn't clear that you want to just copy the branch.conf file. For example, consider 'email'. You can configure email on a per-branch basis in branch.conf. But it doesn't always make sense to copy it.

It might be nice if you were doing:
bzr branch myfeature1 myfeature2

but if you were doing
bzr branch http://jelmers/branch local

Then I wouldn't want to start committing as Jelmer.

A while back we discussed the idea of propagating config settings, and haven't really ever come up with a satisfactory answer. So at the moment, we pretty much do it on a case-by-case basis. We probably could allow plugins, etc, to hook into that.

Changed in bzr:
importance: Undecided → Wishlist
status: New → Incomplete
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.