BranchStack caching misbehaves
Bug #948339 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Vincent Ladeuil | ||
bzr (Ubuntu) |
Fix Released
|
High
|
Jelmer Vernooij |
Bug Description
As seen in:
https:/
Setting values via the config stack triggers a write even though the branch is locked. (test_set_
Retrieving values via the config stack of an unlocked branch does not trigger a read, even if the branch is explicitly unlocked (test_use_
Related branches
lp:~vila/bzr/948339-config-caching
- Martin Packman (community): Approve
-
Diff: 242 lines (+61/-24)8 files modifiedbzrlib/branch.py (+3/-3)
bzrlib/config.py (+14/-11)
bzrlib/plugins/changelog_merge/tests/test_changelog_merge.py (+4/-1)
bzrlib/tests/test_branch.py (+15/-9)
bzrlib/tests/test_config.py (+14/-0)
bzrlib/tests/test_merge_core.py (+1/-0)
doc/developers/configuration.txt (+7/-0)
doc/en/release-notes/bzr-2.6.txt (+3/-0)
Changed in bzr: | |
status: | Triaged → In Progress |
assignee: | nobody → Vincent Ladeuil (vila) |
importance: | Medium → High |
Changed in bzr: | |
milestone: | none → 2.6b2 |
status: | In Progress → Fix Released |
Changed in bzr (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in bzr (Ubuntu): | |
status: | In Progress → Fix Released |
To post a comment you must log in.
> Setting values via the config stack triggers a write even though the branch is locked. (test_set_ delays_ write)
Fixed in the associated branch.
> Retrieving values via the config stack of an unlocked branch does not trigger a read, even if the branch is explicitly unlocked (test_use_ fresh_values)
See https:/ /code.launchpad .net/~vila/ bzr/948339- config- caching/ +merge/ 97256 for why the cost of addressing this is way too high when the aim is to reduce IOs.