rmbranch should refuse removing active branch

Bug #922953 reported by Jelmer Vernooij on 2012-01-28
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar
Medium
Jelmer Vernooij
2.5
Medium
Unassigned
bzr (Ubuntu)
Medium
Jelmer Vernooij
Precise
Medium
Jelmer Vernooij

Bug Description

"bzr rmbranch" shouldn't let the user shoot themselves in the foot by removing the currently active branch.

Instead, it should print an error message if the user tries to remove the active branch and only actually remove the branch when --force is specified.

Related branches

Jelmer Vernooij (jelmer) on 2012-02-23
Changed in bzr:
status: Confirmed → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer) on 2012-02-23
Changed in bzr:
milestone: none → 2.5.0
Vincent Ladeuil (vila) on 2012-02-24
Changed in bzr:
milestone: 2.5.0 → none
Vincent Ladeuil (vila) on 2012-03-15
Changed in bzr:
milestone: none → 2.6b1
status: In Progress → Fix Released
Jelmer Vernooij (jelmer) on 2012-05-28
Changed in bzr (Ubuntu):
status: New → Incomplete
status: Incomplete → Fix Released
importance: Undecided → Medium
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in bzr (Ubuntu Precise):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Jelmer Vernooij (jelmer)

Hello Jelmer, or anyone else affected,

Accepted bzr into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in bzr (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed

I can confirm the version in proposed resolves this issue:

andrew@andrew-laptop:~/Desktop/foo$ bzr branches
  first-colo-branch
* second-colo-branch
andrew@andrew-laptop:~/Desktop/foo$ bzr rmbranch second-colo-branch
bzr: ERROR: Branch is active. Use --force to remove it.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr - 2.5.1-0ubuntu1

---------------
bzr (2.5.1-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
   + Fixes handling of colocated branches in `bzr rmbranch`. LP: #920653
   + rmbranch now refuses to remove active branch. LP: #922953
   + Connecting with HTTPS via HTTP correctly uses host name of destination
     rather than that of proxy. LP: #944696
   + No longer requires tty when GPG signing commits. LP: #847388
   + Fixes unicode erorrs when translated progress task messages
     contain non-ascii text. LP: #966934
   + Fixes display of help for configuration options that overlap
     with other topics. LP: #941672
  * Drop 06_spurious_test_failure: applied upstream.
 -- Jelmer Vernooij <email address hidden> Mon, 28 May 2012 13:36:02 +0200

Changed in bzr (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers