Bzr crashes executing 'pull' over ssh when running windows native on Cygwin

[André]

This seems to be the same problem as in bug #70565 except this time it happens on 'pull' instead of 'branch'.

$ bzr pull
Pull phase: .Connected (version 2.0, client OpenSSH_4.3)
Using saved location: C:/bzr/test.revertbranch/

bzr: ERROR: exceptions.TypeError: encode() argument 1 must be string, not None

Traceback (most recent call last):
  File "bzrlib\commands.pyc", line 650, in run_bzr_catch_errors
  File "bzrlib\commands.pyc", line 612, in run_bzr
  File "bzrlib\commands.pyc", line 304, in run_argv_aliases
  File "bzrlib\builtins.pyc", line 554, in run
  File "bzrlib\decorators.pyc", line 51, in write_locked
  File "bzrlib\workingtree.pyc", line 1173, in pull
  File "bzrlib\decorators.pyc", line 51, in write_locked
  File "bzrlib\branch.pyc", line 1289, in pull
  File "bzrlib\decorators.pyc", line 38, in read_locked
  File "bzrlib\branch.pyc", line 1316, in get_master_branch
  File "bzrlib\branch.pyc", line 119, in open
  File "bzrlib\bzrdir.pyc", line 499, in open
  File "bzrlib\transport\__init__.pyc", line 1036, in get_transport
  File "bzrlib\transport\__init__.pyc", line 1052, in _try_transport_factories
  File "bzrlib\transport\__init__.pyc", line 103, in _loader
  File "bzrlib\transport\sftp.pyc", line 223, in __init__
  File "bzrlib\transport\sftp.pyc", line 834, in _sftp_connect
  File "bzrlib\transport\sftp.pyc", line 1193, in _sftp_connect
  File "bzrlib\transport\sftp.pyc", line 1199, in _sftp_connect_uncached
  File "bzrlib\transport\ssh.pyc", line 247, in connect_sftp
  File "bzrlib\transport\ssh.pyc", line 243, in _connect
  File "bzrlib\transport\ssh.pyc", line 407, in _paramiko_auth
  File "bzrlib\ui\text.pyc", line 85, in get_password
TypeError: encode() argument 1 must be string, not None

bzr 0.14.0 on python 2.5.0.final.0 (win32)
arguments: ['c:\\Program Files\\Bazaar\\bzr.exe', 'pull']

** please send this report to <email address hidden>

[Alexander Belchenko (bialix)]

bzr.exe is not intended to work in Cygwin shell.
We cannot guarantee normal work in such case.
Sorry.

[John A Meinel (jameinel)]

I actually use it that way all the time.

I think the specific problem is that sys.stdout is getting an 'encoding' of None, and we aren't handling that well.

The simple fix is to just fall back to ASCII if encoding is None.

I can look at it a bit closer today.