change find_ids_across_trees to return None when asked to find ids for ['']

Bug #86940 reported by Robert Collins
4
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

find_ids_across_trees currently returns all the ids in all trees when
asked to find ids for the path ['']. This results in double handling of
id data when we dont need to.

find_ids_across_trees should be changed to return None when filenames is
['']: but this will require changing code that currently does not handle
None in this case.

-Rob
 affects /products/bzr
 status confirmed
 importance medium
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Tags: api
Revision history for this message
Aaron Bentley (abentley) wrote :

I think this is totally bogus. find_ids_across_trees should only return None if its input is None.

Functions and methods that get an empty list should treat it as an empty list. I think you want to treat user input of the empty list as meaning wildcard, but that should be done as part of user input parsing, and perhaps not in all cases.

Treating [] differently from all other lists is a bogosity that does not belong in the Bazaar API, e.g. WT.revert

Jelmer Vernooij (jelmer)
tags: added: api
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.