bzr push does too many hpss calls to discover branches are diverged
Bug #850606 reported by
Martin Pool
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned |
Bug Description
After rebasing lp:~mbp/launchpad/643223-dkim-aliases, I did `bzr push` to Launchpad. This eventually reported, correctly, that the branches had diverged, but it took 454 hpss calls and 240s to do so. We ought to be able to detect this case with just one call: read the destination tip and see if it's in the local ancestry of the local tip.
tags: | added: check-for-breezy |
To post a comment you must log in.
There are two forms of non-divergence:
remote tip is in local ancestry: ok to push
local tip is in remote ancestry: pushing is a no-op.
Only if both are false is it diverged. It may still be a
one-round-trip thing though, with some care.
-Rob