get_export_generator() should check argument consistency

Bug #803045 reported by xaav on 2011-06-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Low
Unassigned

Bug Description

when calling bzrlib.export.get_export_generator, an exception should be thrown if one or more of (dest, root) is not set.

This is because the code in bzrlib defaults to dest to set root.

Jelmer Vernooij (jelmer) on 2011-06-28
Changed in bzr:
status: New → Triaged
importance: Undecided → Low
Jelmer Vernooij (jelmer) on 2011-06-28
summary: - Error on exporting
+ get_export_generator() should check argument consistency

I'd rather see the arguments cleaned up a bit; perhaps there should be
multiple factory-type function that take different sets of arguments,
rather than one big function with mutually conflicting arguments.

Martin Pool (mbp) on 2011-07-10
tags: added: api export tech-debt
Jelmer Vernooij (jelmer) on 2017-11-09
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers