The server_exception hook behaviour is unclear if multiple hooks are installed

Bug #789915 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
High
Unassigned
Breezy
Triaged
Medium
Unassigned

Bug Description

Encountered while investigating bug #789167 (fallout from bug #274578).

If several hooks are installed, only the last one will decide
about the exception_caught status.

We probably want to change the definition of the hook to be:

1) return True: the exception has been handled, return False: the
   exception should be re-raised. If a hook returns True, the
   remaining hooks are ignored.

or

2) return an OR'ed expression of all the hooks called.

But I don't think we want to keep the status-quo anyway as we may
re-raise an exception already handled by a hook.

Tags: server
Vincent Ladeuil (vila)
summary: - The server_execption hook behavior unclear if multiple hooks are
+ The server_exception hook behaviour is unclear if multiple hooks are
installed
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: added: server
removed: check-for-breezy
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.