Intermittent test_branch_local_remote failure on windows: permission denied on .pack file

[Vincent Ladeuil]

See http://babune.ladeuil.net:24842/job/selftest-windows/444/testReport/

20.089 abort_write_group failed
20.099 Traceback (most recent call last):
  File "c:\cygwin\home\babune\babune\slaves\xp-32bits.local\workspace\selftest-windows\bzrlib\repository.py", line 275, in abort_write_group
    self._abort_write_group()
  File "c:\cygwin\home\babune\babune\slaves\xp-32bits.local\workspace\selftest-windows\bzrlib\repofmt\pack_repo.py", line 1682, in _abort_write_group
    self._pack_collection._abort_write_group()
  File "c:\cygwin\home\babune\babune\slaves\xp-32bits.local\workspace\selftest-windows\bzrlib\repofmt\pack_repo.py", line 1539, in _abort_write_group
    operation.run_simple()
  File "c:\cygwin\home\babune\babune\slaves\xp-32bits.local\workspace\selftest-windows\bzrlib\cleanup.py", line 135, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "c:\cygwin\home\babune\babune\slaves\xp-32bits.local\workspace\selftest-windows\bzrlib\cleanup.py", line 165, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "c:\cygwin\home\babune\babune\slaves\xp-32bits.local\workspace\selftest-windows\bzrlib\repofmt\pack_repo.py", line 431, in abort
    self.write_stream.close()
  File "c:\cygwin\home\babune\babune\slaves\xp-32bits.local\workspace\selftest-windows\bzrlib\transport\__init__.py", line 236, in close
    del _file_streams[self.transport.abspath(self.relpath)]
KeyError: 'sftp://foo@127.0.0.1:1052/C%3A/docume~1/babune/locals~1/temp/testbzr-g25hys.tmp/ranch.test_branch_local_remote/work/remote/.bzr/repository/upload/jes234x3xhmhlbk8y0g2.pack'

bzrlib.tests.commands.test_commit.TestCommitWithBoundBranch.test_commit_mine_modified fails in a similar way.

The other failures there are different and I'll file different bugs for them.

[Martin Packman (gz)]

This continues to fail on some babune runs but not others:

Passed: <http://babune.ladeuil.net:24842/job/selftest-windows/504/testReport/junit/bzrlib.tests.blackbox.test_branch/TestRemoteBranch/test_branch_local_remote/>

Fails: <http://babune.ladeuil.net:24842/job/selftest-windows/506/testReport/junit/bzrlib.tests.blackbox.test_branch/TestRemoteBranch/test_branch_local_remote/>

[Martin Packman (gz)]

Forward duping as new bug has more information since this became an issue on a large number of tests involving the sftp test server.