socket leak in the test suite again

Bug #784521 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
High
Unassigned

Bug Description

Or rather, an old bug is surfacing again leading to:

- occasional failures on Ubuntu (various releases)
  http://babune.ladeuil.net:24842/job/selftest-natty/159/testReport/junit/bzrlib.tests.test_test_server/TestTCPServerInAThread/test_server_crash_while_responding_TestingThreadingTCPServer_/
  is such an occurrence (there are more)

- making the OSX builds fail with 'Too many open files' which
  unfortunately doesn't get propagated to jenkins

We did some investigations with gz during the bzr sprint and the
leaked threads are related to the dummy connection used to
shutdown the test server.

There is a race condition there (currently not fully understood
but explaining the above cases).

Since this dummy connection was a hack to avoid involving some
form of thread kill, I think it's not worth diagosing and fixing
the race but instead, bite the bullet and go with the kill server
thread approach instead, especially since we dropped support for
python2.4/2.5.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Oh, I forgot to mention that the minimal investigation we did with lp:~vila/bzr/socket-leaks confirmed that the sockets were the ones reported by 'lsof -p nnn' on OSX 10.6 while running 'bzr selftest -s bt.per_branch'.

tags: added: test
Revision history for this message
Vincent Ladeuil (vila) wrote :

Damn, I also forgot to explain that this is the root cause for the OSX builds failures since ~2 weeks and also probably explain the windows ones.

tags: added: babune
Revision history for this message
Andrew Bennetts (spiv) wrote :
Vincent Ladeuil (vila)
tags: added: selftest
removed: test
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers