shelve : change editor does not work when EOL of target file is CRLF.

Bug #783274 reported by IWATA Hidetaka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
High
Unassigned

Bug Description

I have a file in my working tree, eol of which is CRLF.

I can't shelve changes of this file by change editor.
bzr always says 'No changes to shelve' after editing file, regardless of how I edit it.

VERSION INFO:
Bazaar (bzr) 2.4b1
  Python interpreter: C:\DEVELOP\py_envs\bzr2.4\Scripts\python.exe 2.6.6
  Python standard library: C:\DEVELOP\py_envs\bzr2.4\lib
  Platform: Windows-7-6.1.7600
  bzrlib: C:\DEVELOP\py_envs\bzr2.4\lib\site-packages\bzrlib
  Bazaar configuration: C:\Users\iwata\AppData\Roaming\bazaar\2.0
  Bazaar log file: C:\Users\iwata\Documents\.bzr.log

Revision history for this message
IWATA Hidetaka (hid-iwata) wrote :

It seems that this comes from two reasons.

First one is in bzrlib.diff.DiffFromTool.edit_file.
This method returns LF ended lines always, even if original data are CRLF ended lines.

Second is in bzrlib.shelf_ui.Shelver._count_changed_regions.
This method returns wrong value when first or last line are changed.

Jelmer Vernooij (jelmer)
Changed in bzr:
status: New → Confirmed
tags: added: shelve
Changed in bzr:
importance: Undecided → Medium
John A Meinel (jameinel)
Changed in bzr:
importance: Medium → High
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.