Transport.*_multi functions should be removed
Bug #767228 reported by
John A Meinel
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Breezy |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
A long long time ago, I had an idea about how to improve streaming performance without a smart server. We would allow the Transport.*_multi, etc functions take a generator, and yield a generator. Which would allow us to prefetch many files in one request. Thus things like "stat_multi" and "get_multi" were born.
However, we've decided that the only smart way forward is a real custom server protcol. And, in fact, only "Store.copy_multi" is used in real code, and IIRC Store is only used for the really-
They should be shot and buried, so that our test suite doesn't suffer for them.
Related branches
lp:~jelmer/brz/kill-multi
- Jelmer Vernooij: Approve
-
Diff: 511 lines (+34/-224)9 files modifiedbreezy/bzr/repository.py (+2/-1)
breezy/plugins/fastimport/processors/generic_processor.py (+3/-2)
breezy/plugins/weave_fmt/bzrdir.py (+3/-4)
breezy/plugins/weave_fmt/repository.py (+3/-2)
breezy/plugins/weave_fmt/test_bzrdir.py (+2/-1)
breezy/tests/blackbox/test_mkdir.py (+0/-6)
breezy/tests/blackbox/test_serve.py (+2/-1)
breezy/tests/per_transport.py (+17/-113)
breezy/transport/__init__.py (+2/-94)
- Martin Packman: Approve
-
Diff: 511 lines (+34/-224)9 files modifiedbreezy/bzr/repository.py (+2/-1)
breezy/plugins/fastimport/processors/generic_processor.py (+3/-2)
breezy/plugins/weave_fmt/bzrdir.py (+3/-4)
breezy/plugins/weave_fmt/repository.py (+3/-2)
breezy/plugins/weave_fmt/test_bzrdir.py (+2/-1)
breezy/tests/blackbox/test_mkdir.py (+0/-6)
breezy/tests/blackbox/test_serve.py (+2/-1)
breezy/tests/per_transport.py (+17/-113)
breezy/transport/__init__.py (+2/-94)
tags: | added: easy |
no longer affects: | brz |
tags: | added: check-for-breezy |
tags: | removed: check-for-breezy |
Changed in brz: | |
status: | New → Triaged |
importance: | Undecided → Medium |
milestone: | none → 3.0.0 |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in brz: | |
status: | Triaged → In Progress |
Changed in brz: | |
status: | In Progress → Fix Released |
To post a comment you must log in.