test failure: unknown command diff

Bug #761435 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

When I run ' ./bzr selftest -1 -s bt.test_selftest' in trunk, I get

Text attachment: traceback
------------
Traceback (most recent call last):
  File "/home/mbp/lib/python/testtools/runtest.py", line 143, in _run_user
    return fn(*args)
  File "/home/mbp/lib/python/testtools/testcase.py", line 539, in _run_test_method
    return self._get_test_method()()
  File "/home/mbp/bzr/work/bzrlib/tests/test_selftest.py", line 3043, in test_test_suite
    suite = tests.test_suite()
  File "/home/mbp/bzr/work/bzrlib/tests/__init__.py", line 4005, in test_suite
    plugin_suite = plugin.test_suite()
  File "/home/mbp/bzr/work/bzrlib/plugin.py", line 562, in test_suite
    return self.module.test_suite()
  File "/home/mbp/.bazaar/plugins/bzrtools/__init__.py", line 89, in test_suite
    import tests.shelf_tests
  File "/home/mbp/.bazaar/plugins/bzrtools/tests/shelf_tests.py", line 11, in <module>
    from bzrlib.plugins.bzrtools.command_classes import cmd_shelf1
  File "/home/mbp/.bazaar/plugins/bzrtools/command_classes.py", line 531, in <module>
    class cmd_cdiff(BzrToolsCommand):
  File "/home/mbp/.bazaar/plugins/bzrtools/command_classes.py", line 534, in cmd_cdiff
    takes_options = list(get_cmd_object('diff').takes_options) + [
  File "/home/mbp/bzr/work/bzrlib/commands.py", line 240, in get_cmd_object
    raise errors.BzrCommandError('unknown command "%s"' % cmd_name)
BzrCommandError: unknown command "diff"
------------

Tags: test-failure
Martin Pool (mbp)
Changed in bzrtools:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Aaron Bentley (abentley) wrote :

This seems more like a bug in bzr. If you want to make things lazy, go ahead. But when I ask for something by name, it should return it, don't you think?

Aaron Bentley (abentley)
affects: bzrtools → bzr
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 761435] Re: test failure: unknown command diff

It may well be a bzr bug, and it probably is caused by changing to
lazy registration of commands. I haven't dug into it yet.

It does seem like it would be inefficient to make every test that
wants builtin commands exist have to say so, if that's what has
happened.

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 4/15/2011 11:46 PM, Martin Pool wrote:
> It may well be a bzr bug, and it probably is caused by changing to
> lazy registration of commands. I haven't dug into it yet.
>
> It does seem like it would be inefficient to make every test that
> wants builtin commands exist have to say so, if that's what has
> happened.
>

Note that bzrtools adds a test into test_selftest, that fails when diff
is not available as an executable.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2p9hYACgkQJdeBCYSNAAOCGACcDHeZIyxRNJ2OEqwf2l971NDS
w2MAn0gQSXitXWU6sbm6pv74cn4k/XZy
=4eaw
-----END PGP SIGNATURE-----

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.