failUnless & co cause PendingDeprecationWarning

Bug #760435 reported by Martin Pool on 2011-04-14
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Medium
Martin Pool
2.3
Critical
Vincent Ladeuil
BzrTools
Low
Unassigned
bzr-pipeline
Low
Unassigned
bzr (Ubuntu)
Undecided
Unassigned
Natty
High
Jelmer Vernooij

Bug Description

bzr selftest run under -Werror on python2.7 gets a fair number of failures like this:

  File "/home/mbp/bzr/work/bzrlib/tests/__init__.py", line 1469, in failUnlessExists
    self.failUnless(osutils.lexists(path),path+" does not exist")
  File "/usr/lib/python2.7/unittest/case.py", line 601, in deprecated_func
    PendingDeprecationWarning, 2)
PendingDeprecationWarning: Please use assertTrue instead.

We should update them.

Related branches

Andrew Bennetts (spiv) on 2011-04-14
tags: added: easy
John A Meinel (jameinel) wrote :

Since Martin's patch has landed, the only warnings that I saw in the test suite was in bzrtools (and maybe qbzr).

Note that I believe I've run into these with just python2.6 (as visible warnings). So I'm adding bzrtools since it is the same cause.

Changed in bzrtools:
importance: Undecided → Low
status: New → Confirmed
Changed in bzr:
status: In Progress → Fix Released
Aaron Bentley (abentley) on 2011-04-26
Changed in bzr-pipeline:
importance: Undecided → Low
status: New → Confirmed
Aaron Bentley (abentley) on 2011-04-26
Changed in bzr-pipeline:
status: Confirmed → Fix Committed
Changed in bzrtools:
status: Confirmed → Fix Committed
Vincent Ladeuil (vila) on 2011-05-12
Changed in bzr:
milestone: none → 2.4b2
Jelmer Vernooij (jelmer) on 2011-06-08
Changed in bzr (Ubuntu):
status: New → Fix Released
Changed in bzr (Ubuntu Natty):
status: New → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer) on 2011-06-10
Changed in bzr (Ubuntu Natty):
importance: Undecided → High

Accepted bzr into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in bzr (Ubuntu Natty):
status: In Progress → Fix Committed
tags: added: verification-needed
Clint Byrum (clint-fewbar) wrote :

Hello Martin, or anyone else affected,

Accepted bzr into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Jelmer Vernooij (jelmer) wrote :

Verified by running the bzr testsuite from the package in a clean natty install.

tags: added: verification-done
removed: verification-needed
tags: added: verification-needed
removed: verification-done
Jelmer Vernooij (jelmer) on 2011-07-22
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr - 2.3.4-0ubuntu1

---------------
bzr (2.3.4-0ubuntu1) natty-proposed; urgency=low

  * New upstream release.
   + Fix bzr version number in deprecation warnings. LP: #794960
   + Prevent write attemps on remote branch during "bzr up". LP: #786980
   + Fix conflict handling when two trees involved in a merge have different
     root ids. LP: #805809

bzr (2.3.3-0ubuntu1) natty-proposed; urgency=low

  * New upstream release.
   + Fixes deprecation warning on newer versions of Python. LP: #760435
   + Stops 'bzr push' from copying entire repository if a .bzr directory is
     present without a branch. LP: #465517
   + Fixes undefined local variable error when waiting for lock. LP: #733136
   + Fixes lock contention issues pushing to a bound branch. LP: #733350
   + Transfers less data creating a new stacked branch. LP: #737234
   + Several fixes to the test suite, making it more robust. LP: #654733,
      LP: #751824
   + 'bzr merge --pull --preview' actually shows a preview rather than
     actually merging. LP: #760152
   + bzr smart server now supports UTF-8 user names. LP: #659763
   + user identity can now be set based on username and /etc/mailname, not
     requiring it to be set manually. LP: #616878
   + stacking is now fully transitive. LP: #715000
   + makes in-terminal crash report of plugins much shorter. LP: #716389
 -- Jelmer Vernooij <email address hidden> Thu, 14 Jul 2011 21:12:58 +0200

Changed in bzr (Ubuntu Natty):
status: Fix Committed → Fix Released
Aaron Bentley (abentley) on 2011-09-25
Changed in bzrtools:
status: Fix Committed → Fix Released
Aaron Bentley (abentley) on 2012-02-11
Changed in bzr-pipeline:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers